src/effects/SkLumaColorFilter.cpp - Issue 374923002: Goodbye GrEffectRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLumaColorFilter.cpp

Issue 374923002: Goodbye GrEffectRef. (Closed) Base URL: https://skia.googlesource.com/skia.git@noref3

Patch Set: Address comments Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLumaColorFilter.cpp

diff --git a/src/effects/SkLumaColorFilter.cpp b/src/effects/SkLumaColorFilter.cpp

index 54dfc08c19f6f92e33db689bb2219f0a738b8490..4c5e98ab8572d0eca56f0577a83fcb2b8b3f6837 100644

--- a/src/effects/SkLumaColorFilter.cpp

+++ b/src/effects/SkLumaColorFilter.cpp

@@ -60,7 +60,7 @@ void SkLumaColorFilter::toString(SkString* str) const {

#if SK_SUPPORT_GPU

class LumaColorFilterEffect : public GrEffect {

public:

- static GrEffectRef* Create() {

+ static GrEffect* Create() {

GR_CREATE_STATIC_EFFECT(gLumaEffect, LumaColorFilterEffect, ());

return SkRef(gLumaEffect);

}

« no previous file with comments | « src/effects/SkLightingImageFilter.cpp ('k') | src/effects/SkMagnifierImageFilter.cpp » ('j') | no next file with comments »