Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)

Created:
3 years, 5 months ago by ahe
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Deprecate all diagnostics methods that use strings. See #30080. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/9236a3445e383db4be0f9a24d90dc0ffab7e4a14

Patch Set 1 #

Total comments: 1

Patch Set 2 : Merged with 4df146dd9a465d63344330bf3e45524b927c92ec #

Unified diffs Side-by-side diffs Delta from patch set Stats (+920 lines, -921 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 10 chunks +14 lines, -10 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/element_store.dart View 6 chunks +19 lines, -15 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/mock_element.dart View 1 7 chunks +167 lines, -136 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/mock_type.dart View 1 chunk +59 lines, -48 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/tool/summary/mini_ast.dart View 3 chunks +5 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/builder.dart View 4 chunks +5 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/class_builder.dart View 3 chunks +14 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/constructor_reference_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/library_builder.dart View 1 5 chunks +16 lines, -13 lines 0 comments Download
M pkg/front_end/lib/src/fasta/builder/mixin_application_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/command_line.dart View 7 chunks +14 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compile_platform.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/compiler_command_line.dart View 2 chunks +9 lines, -7 lines 0 comments Download
A + pkg/front_end/lib/src/fasta/deprecated_problems.dart View 3 chunks +19 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_class_builder.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_library_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_loader.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_member_builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_target.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/dill/dill_typedef_builder.dart View 2 chunks +5 lines, -4 lines 0 comments Download
D pkg/front_end/lib/src/fasta/errors.dart View 1 chunk +0 lines, -183 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta.dart View 1 4 chunks +7 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/io.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/body_builder.dart View 1 96 chunks +193 lines, -143 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/fasta_accessors.dart View 1 28 chunks +53 lines, -44 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart View 1 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_class_builder.dart View 9 chunks +10 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart View 3 chunks +6 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_field_builder.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_alias_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_function_type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_invalid_type_builder.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart View 10 chunks +19 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_mixin_application_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart View 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart View 1 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_procedure_builder.dart View 6 chunks +15 lines, -10 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_shadow_ast.dart View 1 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_target.dart View 1 12 chunks +27 lines, -18 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/kernel_type_variable_builder.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/kernel/verifier.dart View 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/loader.dart View 1 4 chunks +9 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/messages.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/front_end/lib/src/fasta/modifier.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/token_stream_rewriter.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/quote.dart View 6 chunks +8 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/run.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/scope.dart View 9 chunks +19 lines, -15 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 3 chunks +12 lines, -5 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 9 chunks +12 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_class_builder.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_library_builder.dart View 9 chunks +20 lines, -16 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/source_loader.dart View 1 9 chunks +13 lines, -11 lines 0 comments Download
M pkg/front_end/lib/src/fasta/source/stack_listener.dart View 7 chunks +16 lines, -14 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/environment_variable.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/testing/validating_instrumentation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/translate_uri.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart View 6 chunks +13 lines, -12 lines 0 comments Download
M pkg/front_end/lib/src/fasta/type_inference/type_promotion.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/kernel_generator_impl.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/front_end/test/fasta/shaker_test.dart View 1 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/front_end/tool/_fasta/analyzer_compile.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/front_end/tool/_fasta/log_collector.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/kernel/test/closures_initializers/suite.dart View 1 2 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 2965393002 Patch 60001
Issue 2965393002 Patch 80001
Issue 2965393002 Patch 100001

Messages

Total messages: 7 (3 generated)
ahe
3 years, 5 months ago (2017-07-07 13:57:59 UTC) #3
Siggi Cherem (dart-lang)
https://codereview.chromium.org/2970273004/diff/20001/pkg/front_end/lib/src/fasta/deprecated_problems.dart File pkg/front_end/lib/src/fasta/deprecated_problems.dart (right): https://codereview.chromium.org/2970273004/diff/20001/pkg/front_end/lib/src/fasta/deprecated_problems.dart#newcode36 pkg/front_end/lib/src/fasta/deprecated_problems.dart:36: dynamic deprecated_internalProblem(Object error, I'm not sure we get that ...
3 years, 5 months ago (2017-07-07 15:28:04 UTC) #4
Siggi Cherem (dart-lang)
On 2017/07/07 15:28:04, Siggi Cherem (dart-lang) wrote: > https://codereview.chromium.org/2970273004/diff/20001/pkg/front_end/lib/src/fasta/deprecated_problems.dart > File pkg/front_end/lib/src/fasta/deprecated_problems.dart (right): > > ...
3 years, 5 months ago (2017-07-07 19:26:13 UTC) #5
ahe
3 years, 5 months ago (2017-07-10 09:23:20 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:40001) manually as
9236a3445e383db4be0f9a24d90dc0ffab7e4a14.

Powered by Google App Engine
This is Rietveld 408576698