Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Unified Diff: pkg/front_end/test/fasta/shaker_test.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/kernel_generator_impl.dart ('k') | pkg/front_end/test/fasta/testing/suite.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/test/fasta/shaker_test.dart
diff --git a/pkg/front_end/test/fasta/shaker_test.dart b/pkg/front_end/test/fasta/shaker_test.dart
index 6c1889f362eff64df726932b96aa118b6a745d85..838f0413bad771d7125f11aead7f9010db4a0dc6 100644
--- a/pkg/front_end/test/fasta/shaker_test.dart
+++ b/pkg/front_end/test/fasta/shaker_test.dart
@@ -22,7 +22,8 @@ import 'dart:io' show File;
export 'package:testing/testing.dart' show Chain, runMe;
import 'package:front_end/physical_file_system.dart';
import 'package:front_end/src/fasta/dill/dill_target.dart' show DillTarget;
-import 'package:front_end/src/fasta/errors.dart' show InputError;
+import 'package:front_end/src/fasta/deprecated_problems.dart'
+ show deprecated_InputError;
import 'package:front_end/src/fasta/kernel/kernel_outline_shaker.dart';
import 'package:front_end/src/fasta/kernel/kernel_target.dart'
show KernelTarget;
@@ -118,7 +119,7 @@ class BuildProgram
bool isIncluded(Uri uri) => !_isTreeShaken(uri);
trimProgram(program, isIncluded);
return pass(new _IntermediateData(inputUri, program, showCoreLibraries));
- } on InputError catch (e, s) {
+ } on deprecated_InputError catch (e, s) {
return fail(null, e.error, s);
}
}
@@ -209,9 +210,7 @@ class CheckShaker extends Step<_IntermediateData, String, ChainContext> {
expectedFile.writeAsStringSync(actualResult);
return pass(actualResult);
} else {
- return fail(
- actualResult,
- """
+ return fail(actualResult, """
Please create file ${expectedFile.path} with this content:
$buffer""");
}
« no previous file with comments | « pkg/front_end/lib/src/kernel_generator_impl.dart ('k') | pkg/front_end/test/fasta/testing/suite.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698