Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Unified Diff: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
diff --git a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
index d1ee1511fc6bfc8b793f9e6a83c744fe846b953c..450a01b4bf40f98f035a4c3bcc16114c9763dd5f 100644
--- a/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
+++ b/pkg/front_end/lib/src/fasta/type_inference/type_inference_engine.dart
@@ -4,7 +4,7 @@
import 'package:front_end/src/base/instrumentation.dart';
import 'package:front_end/src/dependency_walker.dart' as dependencyWalker;
-import 'package:front_end/src/fasta/errors.dart';
+import 'package:front_end/src/fasta/deprecated_problems.dart';
import 'package:front_end/src/fasta/kernel/kernel_shadow_ast.dart';
import 'package:front_end/src/fasta/type_inference/type_inference_listener.dart';
import 'package:front_end/src/fasta/type_inference/type_inferrer.dart';
@@ -26,7 +26,7 @@ import 'package:kernel/class_hierarchy.dart';
import 'package:kernel/core_types.dart';
import 'package:kernel/type_algebra.dart';
-import '../errors.dart' show Crash;
+import '../deprecated_problems.dart' show Crash;
import '../messages.dart' show getLocationFromNode;
@@ -403,7 +403,7 @@ abstract class TypeInferenceEngineImpl extends TypeInferenceEngine {
// An method depends on itself (possibly by way of intermediate
// methods). This should never happen, because it would require a
// circular class hierarchy (which Fasta prevents).
- internalError('Circular method inference');
+ deprecated_internalProblem('Circular method inference');
break;
case InferenceState.NotInferredYet:
methodNode.state = InferenceState.Inferring;
@@ -512,7 +512,7 @@ abstract class TypeInferenceEngineImpl extends TypeInferenceEngine {
overriddenType = override.setterType;
}
} else {
- throw internalError(
+ throw deprecated_internalProblem(
'Unexpected overridden member type: ${override.runtimeType}');
}
var superclass = override.enclosingClass;
« no previous file with comments | « pkg/front_end/lib/src/fasta/translate_uri.dart ('k') | pkg/front_end/lib/src/fasta/type_inference/type_inferrer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698