Deprecate all diagnostics methods that use strings.

pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.kernel_enum_builder;
 
 import 'package:kernel/ast.dart'
     show
         Arguments,
         Class,
@@ skipping 139 matching lines @@
         parent,
         charOffset,
         charOffset,
         charEndOffset);
     members["toString"] = toStringBuilder;
     String className = name;
     for (int i = 0; i < constantNamesAndOffsets.length; i += 2) {
       String name = constantNamesAndOffsets[i];
       int charOffset = constantNamesAndOffsets[i + 1];
       if (members.containsKey(name)) {
-        parent.addCompileTimeError(charOffset, "Duplicated name: '$name'.");
+        parent.deprecated_addCompileTimeError(
+            charOffset, "Duplicated name: '$name'.");
         constantNamesAndOffsets[i] = null;
         continue;
       }
       if (name == className) {
-        parent.addCompileTimeError(
+        parent.deprecated_addCompileTimeError(
             charOffset,
             "Name of enum constant '$name' can't be the same as the enum's "
             "own name.");
         constantNamesAndOffsets[i] = null;
         continue;
       }
       KernelFieldBuilder fieldBuilder = new KernelFieldBuilder(null, selfType,
           name, constMask | staticMask, parent, charOffset, null, true);
       members[name] = fieldBuilder;
       toStringEntries.add(new MapEntry(
@@ skipping 30 matching lines @@
   KernelTypeBuilder get mixedInType => null;
 
   InterfaceType buildType(
       LibraryBuilder library, List<KernelTypeBuilder> arguments) {
     return cls.rawType;
   }
 
   @override
   Class build(KernelLibraryBuilder libraryBuilder, LibraryBuilder coreLibrary) {
     if (constantNamesAndOffsets.isEmpty) {
-      libraryBuilder.addCompileTimeError(
+      libraryBuilder.deprecated_addCompileTimeError(
           -1, "An enum declaration can't be empty.");
     }
     intType.resolveIn(coreLibrary.scope);
     stringType.resolveIn(coreLibrary.scope);
     objectType.resolveIn(coreLibrary.scope);
     listType.resolveIn(coreLibrary.scope);
     toStringMap.keyType = intType.build(libraryBuilder);
     toStringMap.valueType = stringType.build(libraryBuilder);
     KernelFieldBuilder indexFieldBuilder = this["index"];
     Field indexField = indexFieldBuilder.build(libraryBuilder);
@@ skipping 24 matching lines @@
             new VariableGet(constructor.function.positionalParameters.single))
           ..parent = constructor);
     KernelClassBuilder objectClass = objectType.builder;
     MemberBuilder superConstructor = objectClass.findConstructorOrFactory(
         "", charOffset, fileUri, libraryBuilder);
     if (superConstructor == null || !superConstructor.isConstructor) {
       // TODO(ahe): Ideally, we would also want to check that [Object]'s
       // unnamed constructor requires no arguments. But that information isn't
       // always available at this point, and it's not really a situation that
       // can happen unless you start modifying the SDK sources.
-      addCompileTimeError(-1, "'Object' has no unnamed constructor.");
+      deprecated_addCompileTimeError(
+          -1, "'Object' has no unnamed constructor.");
     } else {
       constructor.initializers.add(
           new SuperInitializer(superConstructor.target, new Arguments.empty())
             ..parent = constructor);
     }
     int index = 0;
     for (int i = 0; i < constantNamesAndOffsets.length; i += 2) {
       String constant = constantNamesAndOffsets[i];
       if (constant != null) {
         KernelFieldBuilder field = this[constant];
         field.build(libraryBuilder);
         Arguments arguments =
             new Arguments(<Expression>[new IntLiteral(index++)]);
         field.initializer =
             new ConstructorInvocation(constructor, arguments, isConst: true);
       }
     }
     return super.build(libraryBuilder, coreLibrary);
   }
 
   @override
   Builder findConstructorOrFactory(
       String name, int charOffset, Uri uri, LibraryBuilder library) {
     return null;
   }
 }