Deprecate all diagnostics methods that use strings.

pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 /// A transformation to create a self-contained modular kernel without
 /// unnecessary references to other libraries.
 library fasta.kernel.kernel_outline_shaker;
 
 import 'package:kernel/ast.dart';
 import 'package:kernel/core_types.dart';
 
-import '../errors.dart' show internalError;
+import '../deprecated_problems.dart' show deprecated_internalProblem;
 
 /// Removes unnecessary libraries, classes, and members from [program].
 ///
 /// This applies a simple "tree-shaking" technique: the full body of libraries
 /// whose URI match [isIncluded] is preserved, and so is the outline of the
 /// members and classes which are transitively visible from the
 /// included libraries.
 ///
 /// The intent is that the resulting program has the entire code that is meant
 /// to be included and the minimum required to prevent dangling references and
@@ skipping 233 matching lines @@
 
   @override
   visitStaticInvocation(StaticInvocation node) {
     data.markMember(node.target);
     node.visitChildren(this);
   }
 
   @override
   visitDirectMethodInvocation(DirectMethodInvocation node) {
     if (node.receiver is! ThisExpression) {
-      return internalError('Direct calls are only supported on "this"');
+      return deprecated_internalProblem(
+          'Direct calls are only supported on "this"');
     }
     data.markMember(node.target);
     node.visitChildren(this);
   }
 
   @override
   visitMethodInvocation(MethodInvocation node) {
     data.markMember(node.interfaceTarget);
     node.visitChildren(this);
   }
@@ skipping 53 matching lines @@
   }
 
   @override
   visitSupertype(Supertype node) {
     data.markClass(node.classNode);
     node.visitChildren(this);
   }
 
   @override
   visitTypedefReference(Typedef node) {
-    return internalError('not implemented');
+    return deprecated_internalProblem('not implemented');
   }
 }
 
 /// Transformer that trims everything in the excluded libraries that is not
 /// marked as preserved by the given [RetainedData]. For every member in these
 /// excluded libraries, this transformer also removes function bodies and
 /// initializers.
 class KernelOutlineShaker extends Transformer {
   final RetainedData data;
   final Filter isIncluded;
@@ skipping 45 matching lines @@
   /// Types appear to be encoded directly, so we have no need to preserve
   /// typedefs.
   // TODO(sigmund): revisit if this is not the case, the `inputError` in
   // [RootsMarker] is meant to detect this.
   Typedef visitTypedef(Typedef node) => null;
 
   TreeNode defaultTreeNode(TreeNode node) => node;
 }
 
 typedef bool Filter(Uri uri);