Deprecate all diagnostics methods that use strings.

pkg/front_end/lib/src/fasta/scope.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.scope;
 
 import 'builder/builder.dart' show Builder, TypeVariableBuilder;
 
-import 'errors.dart' show InputError, internalError;
+import 'deprecated_problems.dart'
+    show deprecated_InputError, deprecated_internalProblem;
 
 class MutableScope {
   /// Names declared in this scope.
   Map<String, Builder> local;
 
   /// Setters declared in this scope.
   Map<String, Builder> setters;
 
   /// The scope that this scope is nested within, or `null` if this is the top
   /// level scope.
@@ skipping 22 matching lines @@
             isModifiable: isModifiable);
 
   Scope.immutable()
       : this(const <String, Builder>{}, const <String, Builder>{}, null,
             isModifiable: false);
 
   Scope.nested(Scope parent, {bool isModifiable: true})
       : this(<String, Builder>{}, null, parent, isModifiable: isModifiable);
 
   /// Don't use this. Use [becomePartOf] instead.
-  void set local(_) => internalError("Unsupported operation.");
+  void set local(_) => deprecated_internalProblem("Unsupported operation.");
 
   /// Don't use this. Use [becomePartOf] instead.
-  void set setters(_) => internalError("Unsupported operation.");
+  void set setters(_) => deprecated_internalProblem("Unsupported operation.");
 
   /// Don't use this. Use [becomePartOf] instead.
-  void set parent(_) => internalError("Unsupported operation.");
+  void set parent(_) => deprecated_internalProblem("Unsupported operation.");
 
   /// This scope becomes equivalent to [scope]. This is used for parts to
   /// become part of their library's scope.
   void becomePartOf(Scope scope) {
     assert(parent.parent == null);
     assert(scope.parent.parent == null);
     super.local = scope.local;
     super.setters = scope.setters;
     super.parent = scope.parent;
   }
@@ skipping 43 matching lines @@
   }
 
   Builder lookup(String name, int charOffset, Uri fileUri,
       {bool isInstanceScope: true}) {
     recordUse(name, charOffset, fileUri);
     Builder builder =
         lookupIn(name, charOffset, fileUri, local, isInstanceScope);
     if (builder != null) return builder;
     builder = lookupIn(name, charOffset, fileUri, setters, isInstanceScope);
     if (builder != null && !builder.hasProblem) {
-      return new AccessErrorBuilder(name, builder, charOffset, fileUri);
+      return new deprecated_AccessErrorBuilder(
+          name, builder, charOffset, fileUri);
     }
     if (!isInstanceScope) {
       // For static lookup, do not seach the parent scope.
       return builder;
     }
     return builder ?? parent?.lookup(name, charOffset, fileUri);
   }
 
   Builder lookupSetter(String name, int charOffset, Uri fileUri,
       {bool isInstanceScope: true}) {
     recordUse(name, charOffset, fileUri);
     Builder builder =
         lookupIn(name, charOffset, fileUri, setters, isInstanceScope);
     if (builder != null) return builder;
     builder = lookupIn(name, charOffset, fileUri, local, isInstanceScope);
     if (builder != null && !builder.hasProblem) {
-      return new AccessErrorBuilder(name, builder, charOffset, fileUri);
+      return new deprecated_AccessErrorBuilder(
+          name, builder, charOffset, fileUri);
     }
     if (!isInstanceScope) {
       // For static lookup, do not seach the parent scope.
       return builder;
     }
     return builder ?? parent?.lookupSetter(name, charOffset, fileUri);
   }
 
   bool hasLocalLabel(String name) => labels != null && labels.containsKey(name);
 
   void declareLabel(String name, Builder target) {
     if (isModifiable) {
       labels ??= <String, Builder>{};
       labels[name] = target;
     } else {
-      internalError("Can't extend an unmodifiable scope.");
+      deprecated_internalProblem("Can't extend an unmodifiable scope.");
     }
   }
 
   void forwardDeclareLabel(String name, Builder target) {
     declareLabel(name, target);
     forwardDeclaredLabels ??= <String, Builder>{};
     forwardDeclaredLabels[name] = target;
   }
 
   void claimLabel(String name) {
@@ skipping 10 matching lines @@
 
   Builder lookupLabel(String name) {
     return (labels == null ? null : labels[name]) ?? parent?.lookupLabel(name);
   }
 
   /// Declares that the meaning of [name] in this scope is [builder].
   ///
   /// If name was used previously in this scope, this method returns an error
   /// that should be reported as a compile-time error. The position of this
   /// error is given by [charOffset] and [fileUri].
-  InputError declare(
+  deprecated_InputError declare(
       String name, Builder builder, int charOffset, Uri fileUri) {
     if (isModifiable) {
       if (usedNames?.containsKey(name) ?? false) {
-        return new InputError(
+        return new deprecated_InputError(
             fileUri, usedNames[name], "Previous use of '$name'.");
       }
       recordUse(name, charOffset, fileUri);
       local[name] = builder;
     } else {
-      internalError("Can't extend an unmodifiable scope.");
+      deprecated_internalProblem("Can't extend an unmodifiable scope.");
     }
     return null;
   }
 
   void merge(Scope scope,
       buildAmbiguousBuilder(String name, Builder existing, Builder member)) {
     Map<String, Builder> map = local;
 
     void mergeMember(String name, Builder member) {
       Builder existing = map[name];
@@ skipping 59 matching lines @@
 
   final Builder builder;
 
   ProblemBuilder(this.name, this.builder, int charOffset, Uri fileUri)
       : super(null, charOffset, fileUri);
 
   get target => null;
 
   bool get hasProblem => true;
 
-  String get message;
+  String get deprecated_message;
 
   @override
   String get fullNameForErrors => name;
 }
 
 /// Represents a [builder] that's being accessed incorrectly. For example, an
 /// attempt to write to a final field, or to read from a setter.
-class AccessErrorBuilder extends ProblemBuilder {
-  AccessErrorBuilder(String name, Builder builder, int charOffset, Uri fileUri)
+class deprecated_AccessErrorBuilder extends ProblemBuilder {
+  deprecated_AccessErrorBuilder(
+      String name, Builder builder, int charOffset, Uri fileUri)
       : super(name, builder, charOffset, fileUri);
 
   Builder get parent => builder;
 
   bool get isFinal => builder.isFinal;
 
   bool get isField => builder.isField;
 
   bool get isRegularMethod => builder.isRegularMethod;
 
   bool get isGetter => !builder.isGetter;
 
   bool get isSetter => !builder.isSetter;
 
   bool get isInstanceMember => builder.isInstanceMember;
 
   bool get isStatic => builder.isStatic;
 
   bool get isTopLevel => builder.isTopLevel;
 
   bool get isTypeDeclaration => builder.isTypeDeclaration;
 
   bool get isLocal => builder.isLocal;
 
-  String get message => "Access error: '$name'.";
+  String get deprecated_message => "Access error: '$name'.";
 }
 
 class AmbiguousBuilder extends ProblemBuilder {
   AmbiguousBuilder(String name, Builder builder, int charOffset, Uri fileUri)
       : super(name, builder, charOffset, fileUri);
 
-  String get message => "Duplicated named: '$name'.";
+  String get deprecated_message => "Duplicated named: '$name'.";
 }