Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
index 0f59af0e01ae47741650f4650a3e9cccc89b2ac2..12b978ec040f5d0d95aa53b10745de03715abfbc 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_outline_shaker.dart
@@ -9,7 +9,7 @@ library fasta.kernel.kernel_outline_shaker;
import 'package:kernel/ast.dart';
import 'package:kernel/core_types.dart';
-import '../errors.dart' show internalError;
+import '../deprecated_problems.dart' show deprecated_internalProblem;
/// Removes unnecessary libraries, classes, and members from [program].
///
@@ -263,7 +263,8 @@ class RootsMarker extends RecursiveVisitor {
@override
visitDirectMethodInvocation(DirectMethodInvocation node) {
if (node.receiver is! ThisExpression) {
- return internalError('Direct calls are only supported on "this"');
+ return deprecated_internalProblem(
+ 'Direct calls are only supported on "this"');
}
data.markMember(node.target);
node.visitChildren(this);
@@ -337,7 +338,7 @@ class RootsMarker extends RecursiveVisitor {
@override
visitTypedefReference(Typedef node) {
- return internalError('not implemented');
+ return deprecated_internalProblem('not implemented');
}
}

Powered by Google App Engine
This is Rietveld 408576698