Deprecate all diagnostics methods that use strings.

pkg/front_end/lib/src/fasta/source/source_library_builder.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.source_library_builder;
 
 import 'package:front_end/src/scanner/token.dart' show Token;
 
 import 'package:kernel/ast.dart' show ProcedureKind;
 
 import '../../base/resolve_relative_uri.dart' show resolveRelativeUri;
 
 import '../combinator.dart' show Combinator;
 
-import '../errors.dart' show inputError, internalError;
+import '../deprecated_problems.dart'
+    show deprecated_inputError, deprecated_internalProblem;
 
 import '../export.dart' show Export;
 
 import '../import.dart' show Import;
 
 import 'source_loader.dart' show SourceLoader;
 
 import '../builder/builder.dart'
     show
         Builder,
@@ skipping 249 matching lines @@
     // implementation of MemberBuilder.isTopLevel to test explicitly for a
     // LibraryBuilder.
     if (currentDeclaration == libraryDeclaration) {
       if (builder is MemberBuilder) {
         builder.parent = this;
       } else if (builder is TypeDeclarationBuilder) {
         builder.parent = this;
       } else if (builder is PrefixBuilder) {
         assert(builder.parent == this);
       } else {
-        return internalError("Unhandled: ${builder.runtimeType}");
+        return deprecated_internalProblem("Unhandled: ${builder.runtimeType}");
       }
     } else {
       assert(currentDeclaration.parent == libraryDeclaration);
     }
     bool isConstructor = builder is ProcedureBuilder &&
         (builder.isConstructor || builder.isFactory);
     Map<String, Builder> members = isConstructor
         ? currentDeclaration.constructors
         : (builder.isSetter
             ? currentDeclaration.setters
             : currentDeclaration.members);
     Builder existing = members[name];
     builder.next = existing;
     if (builder is PrefixBuilder && existing is PrefixBuilder) {
       assert(existing.next == null);
       Builder deferred;
       Builder other;
       if (builder.deferred) {
         deferred = builder;
         other = existing;
       } else if (existing.deferred) {
         deferred = existing;
         other = builder;
       }
       if (deferred != null) {
-        addCompileTimeError(
+        deprecated_addCompileTimeError(
             deferred.charOffset,
             "Can't use the name '$name' for a deferred library, "
             "as the name is used elsewhere.");
-        addCompileTimeError(other.charOffset, "'$name' is used here.");
+        deprecated_addCompileTimeError(
+            other.charOffset, "'$name' is used here.");
       }
       return existing
         ..exports.merge(builder.exports,
             (String name, Builder existing, Builder member) {
           return buildAmbiguousBuilder(name, existing, member, charOffset);
         });
     } else if (isDuplicatedDefinition(existing, builder)) {
-      addCompileTimeError(charOffset, "Duplicated definition of '$name'.");
+      deprecated_addCompileTimeError(
+          charOffset, "Duplicated definition of '$name'.");
     }
     return members[name] = builder;
   }
 
   bool isDuplicatedDefinition(Builder existing, Builder other) {
     if (existing == null) return false;
     Builder next = existing.next;
     if (next == null) {
       if (existing.isGetter && other.isSetter) return false;
       if (existing.isSetter && other.isGetter) return false;
@@ skipping 27 matching lines @@
       int charOffset = list[2];
       addBuilder(name, builder, charOffset);
       buildBuilder(builder, coreLibrary);
     }
     canAddImplementationBuilders = false;
 
     scope.setters.forEach((String name, Builder setter) {
       Builder member = scopeBuilder[name];
       if (member == null || !member.isField || member.isFinal) return;
       // TODO(ahe): charOffset is missing.
-      addCompileTimeError(
+      deprecated_addCompileTimeError(
           setter.charOffset, "Conflicts with member '${name}'.");
-      addCompileTimeError(
+      deprecated_addCompileTimeError(
           member.charOffset, "Conflicts with setter '${name}'.");
     });
 
     return null;
   }
 
   /// Used to add implementation builder during the call to [build] above.
   /// Currently, only anonymous mixins are using implementation builders (see
   /// [KernelMixinApplicationBuilder]
   /// (../kernel/kernel_mixin_application_builder.dart)).
   void addImplementationBuilder(String name, Builder builder, int charOffset) {
     assert(canAddImplementationBuilders, "$uri");
     implementationBuilders.add([name, builder, charOffset]);
   }
 
   void validatePart() {
     if (parts.isNotEmpty) {
-      inputError(fileUri, -1,
+      deprecated_inputError(fileUri, -1,
           "A file that's a part of a library can't have parts itself.");
     }
     if (exporters.isNotEmpty) {
       Export export = exporters.first;
-      inputError(
+      deprecated_inputError(
           export.fileUri, export.charOffset, "A part can't be exported.");
     }
   }
 
   void includeParts() {
     Set<Uri> seenParts = new Set<Uri>();
     for (SourceLibraryBuilder<T, R> part in parts.toList()) {
       if (part == this) {
-        addCompileTimeError(-1, "A file can't be a part of itself.");
+        deprecated_addCompileTimeError(-1, "A file can't be a part of itself.");
       } else if (seenParts.add(part.fileUri)) {
         includePart(part);
       } else {
-        addCompileTimeError(
+        deprecated_addCompileTimeError(
             -1, "Can't use '${part.fileUri}' as a part more than once.");
       }
     }
   }
 
   void includePart(SourceLibraryBuilder<T, R> part) {
     if (part.partOfUri != null) {
       if (uri.resolve(part.partOfUri) != uri) {
         // This is a warning, but the part is still included.
-        addWarning(
+        deprecated_addWarning(
             -1,
             "Using '${part.relativeFileUri}' as part of '$uri' but its "
             "'part of' declaration says '${part.partOfUri}'.");
         if (uri.scheme == "dart" && relativeFileUri.endsWith(part.partOfUri)) {
-          addWarning(-1, "See https://github.com/dart-lang/sdk/issues/30072.");
+          deprecated_addWarning(
+              -1, "See https://github.com/dart-lang/sdk/issues/30072.");
         }
       }
     } else if (part.partOfName != null) {
       if (name != null) {
         if (part.partOfName != name) {
           // This is a warning, but the part is still included.
-          addWarning(
+          deprecated_addWarning(
               -1,
               "Using '${part.relativeFileUri}' as part of '$name' but its "
               "'part of' declaration says '${part.partOfName}'.");
         }
       } else {
         // This is a warning, but the part is still included.
-        addWarning(
+        deprecated_addWarning(
             -1,
             "Using '${part.relativeFileUri}' as part of '${relativeFileUri}' "
             "but its 'part of' declaration says '${part.partOfName}'.\n"
             "Try changing the 'part of' declaration to use a relative "
             "file name.");
       }
     } else if (name != null) {
       // This is an error, and the part isn't included.
       assert(!part.isPart);
-      addCompileTimeError(
+      deprecated_addCompileTimeError(
           -1,
           "Can't use ${part.fileUri} as a part, because it has no 'part of'"
           " declaration.");
       parts.remove(part);
       return;
     }
     part.forEach((String name, Builder builder) {
       if (builder.next != null) {
         assert(builder.next.next == null);
         addBuilder(name, builder.next, builder.next.charOffset);
@@ skipping 169 matching lines @@
   /// synthesize type variables on the factory matching the class'.
   void addFactoryDeclaration(
       ProcedureBuilder procedure, DeclarationBuilder<T> factoryDeclaration) {
     factoryDeclarations[procedure] = factoryDeclaration;
   }
 
   Scope toScope(Scope parent) {
     return new Scope(members, setters, parent, isModifiable: false);
   }
 }