Deprecate all diagnostics methods that use strings.

pkg/analyzer/lib/src/fasta/element_store.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library fasta.analyzer.element_store;
 
 import 'package:analyzer/src/kernel/loader.dart' show ReferenceLevelLoader;
 
 import 'package:kernel/ast.dart';
 
 import 'package:analyzer/analyzer.dart' show ParameterKind;
 
 import 'package:analyzer/analyzer.dart' as analyzer;
 
 import 'package:analyzer/dart/element/element.dart';
 
 import 'package:analyzer/dart/element/type.dart' as analyzer;
 
-import 'package:front_end/src/fasta/errors.dart' show internalError;
+import 'package:front_end/src/fasta/deprecated_problems.dart'
+    show deprecated_internalProblem;
 
 import 'package:front_end/src/fasta/kernel/kernel_builder.dart';
 
 import 'package:front_end/src/fasta/dill/dill_member_builder.dart';
 
 import 'mock_element.dart';
 
 import 'mock_type.dart';
 
 abstract class ElementStore implements ReferenceLevelLoader {
@@ skipping 49 matching lines @@
         do {
           if (builder is ClassBuilder) {
             elements[builder] = new KernelClassElement(builder);
           } else if (builder is KernelFunctionTypeAliasBuilder) {
             elements[builder] = new KernelFunctionTypeAliasElement(builder);
           } else if (builder is DillMemberBuilder) {
             Member member = builder.member;
             if (member is Field) {} else if (member is Procedure) {
               buildDillFunctionElement(builder, unit, elements);
             } else {
-              internalError("Unhandled $name ${member.runtimeType} in $uri");
+              deprecated_internalProblem(
+                  "Unhandled $name ${member.runtimeType} in $uri");
             }
           } else if (builder is KernelProcedureBuilder) {
             buildKernelFunctionElement(builder, unit, elements);
           } else if (builder is BuiltinTypeBuilder) {
             // TODO(ahe): Set up elements for dynamic and void.
           } else {
-            internalError("Unhandled $name ${builder.runtimeType} in $uri");
+            deprecated_internalProblem(
+                "Unhandled $name ${builder.runtimeType} in $uri");
           }
           builder = builder.next;
         } while (builder != null);
       });
     });
     return new ElementStoreImplementation.internal(coreLibrary, elements);
   }
 
   bool get ignoreRedirectingFactories => false;
 
   Constructor getCoreClassConstructorReference(String className,
       {String constructorName, String library}) {
     assert(library == null);
     return coreLibrary
         .getConstructor(className, constructorName: constructorName)
         .target;
   }
 
   Library getLibraryReference(LibraryElement element) {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 
   Class getClassReference(covariant KernelClassElement cls) => cls.builder.cls;
 
   Member getMemberReference(Element element) {
     if (element is KernelFunctionElement) {
       return element.procedure;
     } else {
-      return internalError("getMemberReference(${element.runtimeType})");
+      return deprecated_internalProblem(
+          "getMemberReference(${element.runtimeType})");
     }
   }
 
-  Class getRootClassReference() => internalError("not supported.");
+  Class getRootClassReference() => deprecated_internalProblem("not supported.");
 
   Constructor getRootClassConstructorReference() {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 
   Class getCoreClassReference(String className) {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 
   TypeParameter tryGetClassTypeParameter(TypeParameterElement element) {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 
   Class getSharedMixinApplicationClass(
       Library library, Class supertype, Class mixin) {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 
   bool get strongMode => false;
 
   static void buildDillFunctionElement(DillMemberBuilder builder,
       KernelCompilationUnitElement unit, Map<Builder, Element> elements) {
     Procedure procedure = builder.member;
     List<VariableDeclaration> positionalParameters =
         procedure.function.positionalParameters;
     List<VariableDeclaration> namedParameters =
@@ skipping 97 matching lines @@
   String get name => variable.name.name;
 
   bool get isFinal => false; // TODO(ahe): implement this.
 
   bool get isConst => false; // TODO(ahe): implement this.
 
   analyzer.VariableDeclaration get target => variable;
 
   get type => null;
 
-  get constantValue => internalError("not supported.");
+  get constantValue => deprecated_internalProblem("not supported.");
 
-  computeConstantValue() => internalError("not supported.");
+  computeConstantValue() => deprecated_internalProblem("not supported.");
 }
 
 /// Both an [Element] and [Builder] to using memory to store local elements in
 /// [ElementStore].
 class AnalyzerParameterElement extends MockParameterElement {
   final analyzer.FormalParameter parameter;
 
   AnalyzerParameterElement(this.parameter);
 
   String get name => parameter.identifier.name;
@@ skipping 15 matching lines @@
   }
 }
 
 class KernelFunctionTypeAliasElement extends MockFunctionTypeAliasElement {
   final KernelFunctionTypeAliasBuilder builder;
 
   KernelFunctionTypeAliasElement(this.builder);
 
   @override
   analyzer.DartType get returnType {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 
   @override
   analyzer.FunctionType get type {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 
   @override
   List<TypeParameterElement> get typeParameters {
-    return internalError("not supported.");
+    return deprecated_internalProblem("not supported.");
   }
 }
 
 class KernelInterfaceType extends MockInterfaceType {
   final KernelClassElement element;
 
   KernelInterfaceType(this.element);
 
   List<analyzer.DartType> get typeArguments => const <analyzer.DartType>[];
 }