Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
index 873c3246a15e433f7712c50e29408bcf2dc7f7a3..6bdf5529e24715ef431f791fe51db037d7f0f4e3 100644
--- a/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_named_type_builder.dart
@@ -6,7 +6,7 @@ library fasta.kernel_interface_type_builder;
import 'package:kernel/ast.dart' show DartType, DynamicType, Supertype;
-import '../messages.dart' show warning;
+import '../messages.dart' show deprecated_warning;
import 'kernel_builder.dart'
show
@@ -27,18 +27,18 @@ class KernelNamedTypeBuilder
KernelInvalidTypeBuilder buildInvalidType(String name) {
// TODO(ahe): Record error instead of printing.
- warning(fileUri, charOffset, "Type not found: '$name'.");
+ deprecated_warning(fileUri, charOffset, "Type not found: '$name'.");
return new KernelInvalidTypeBuilder(name, charOffset, fileUri);
}
DartType handleMissingType() {
// TODO(ahe): Record error instead of printing.
- warning(fileUri, charOffset, "No type for: '$name'.");
+ deprecated_warning(fileUri, charOffset, "No type for: '$name'.");
return const DynamicType();
}
Supertype handleMissingSupertype() {
- warning(fileUri, charOffset, "No type for: '$name'.");
+ deprecated_warning(fileUri, charOffset, "No type for: '$name'.");
return null;
}
@@ -46,7 +46,8 @@ class KernelNamedTypeBuilder
String message = builder.isTypeVariable
? "The type variable '$name' can't be used as supertype."
: "The type '$name' can't be used as supertype.";
- library.addCompileTimeError(charOffset, message, fileUri: fileUri);
+ library.deprecated_addCompileTimeError(charOffset, message,
+ fileUri: fileUri);
return null;
}

Powered by Google App Engine
This is Rietveld 408576698