Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Side by Side Diff: pkg/front_end/lib/src/fasta/io.dart

Issue 2970273004: Deprecate all diagnostics methods that use strings. (Closed)
Patch Set: Merged with 4df146dd9a465d63344330bf3e45524b927c92ec Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2017, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.io; 5 library fasta.io;
6 6
7 import 'dart:async' show Future; 7 import 'dart:async' show Future;
8 8
9 import 'dart:io' show FileSystemException; 9 import 'dart:io' show FileSystemException;
10 10
11 import 'errors.dart' show inputError; 11 import 'deprecated_problems.dart' show deprecated_inputError;
12 12
13 import 'scanner/io.dart' as scanner_io show readBytesFromFile; 13 import 'scanner/io.dart' as scanner_io show readBytesFromFile;
14 14
15 Future<List<int>> readBytesFromFile(Uri uri, 15 Future<List<int>> readBytesFromFile(Uri uri,
16 {bool ensureZeroTermination: true}) async { 16 {bool ensureZeroTermination: true}) async {
17 try { 17 try {
18 return await scanner_io.readBytesFromFile(uri, 18 return await scanner_io.readBytesFromFile(uri,
19 ensureZeroTermination: ensureZeroTermination); 19 ensureZeroTermination: ensureZeroTermination);
20 } on FileSystemException catch (e) { 20 } on FileSystemException catch (e) {
21 String message = e.message; 21 String message = e.message;
22 String osMessage = e.osError?.message; 22 String osMessage = e.osError?.message;
23 if (osMessage != null && osMessage.isNotEmpty) { 23 if (osMessage != null && osMessage.isNotEmpty) {
24 message = osMessage; 24 message = osMessage;
25 } 25 }
26 return inputError(uri, -1, message); 26 return deprecated_inputError(uri, -1, message);
27 } 27 }
28 } 28 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/fasta.dart ('k') | pkg/front_end/lib/src/fasta/kernel/body_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698