Propagate the user gesture bit when requesting push messaging permission.

Propagate the user gesture bit when requesting push messaging permission.

Currently, directly subscribing to push messages without having
previously been granted notifications permissions results in
a permission prompt to the user. This prompt is hardcoded to always tell
the permissions layer that it was made by a user gesture, which may or
may not be the case.

This CL plumbs the user gesture bit from the renderer to the browser
when PushManager.subscribe() is called. This means permission metrics
for push will now have the correct values recorded for the user gesture bit.

BUG=733483
Review-Url: https://codereview.chromium.org/2935333003
Cr-Commit-Position: refs/heads/master@{#479965}
Committed: https://chromium.googlesource.com/chromium/src/+/6ba3fa621ea462377f2d6f189ae1eb186f9cae16

[dominickn, 2017-06-15 04:32:28]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 04:32:42]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-06-15 05:17:42]

Description was changed from

==========
Propagate the user gesture bit when requesting push messaging permission.

Currently, directly subscribing to push messages without having
previously been granted notifications permissions results in
a permission prompt to the user. This prompt is hardcoded to always have
a user gesture, which may or may not be the case.

This CL plumbs the user gesture bit from the renderer to the browser.
This means permission metrics for push will now have the correct values
recorded for the user gesture bit.

BUG=733483
==========

to

==========
Propagate the user gesture bit when requesting push messaging permission.

Currently, directly subscribing to push messages without having
previously been granted notifications permissions results in
a permission prompt to the user. This prompt is hardcoded to always have
a user gesture, which may or may not be the case.

This CL plumbs the user gesture bit from the renderer to the browser
when PushManager.subscribe() is called. This means permission metrics
for push will now have the correct values recorded for the user gesture bit.

BUG=733483
==========

[dominickn, 2017-06-15 05:17:43]

dominickn@chromium.org changed reviewers:
+ peter@chromium.org

[commit-bot: I haz the power, 2017-06-15 05:42:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 05:42:48]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dominickn, 2017-06-15 06:16:46]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-15 06:16:59]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2017-06-15 07:24:48]

PTAL, thanks!

[dominickn, 2017-06-15 07:37:30]

Description was changed from

==========
Propagate the user gesture bit when requesting push messaging permission.

Currently, directly subscribing to push messages without having
previously been granted notifications permissions results in
a permission prompt to the user. This prompt is hardcoded to always have
a user gesture, which may or may not be the case.

This CL plumbs the user gesture bit from the renderer to the browser
when PushManager.subscribe() is called. This means permission metrics
for push will now have the correct values recorded for the user gesture bit.

BUG=733483
==========

to

==========
Propagate the user gesture bit when requesting push messaging permission.

Currently, directly subscribing to push messages without having
previously been granted notifications permissions results in
a permission prompt to the user. This prompt is hardcoded to always tell
the permissions layer that it was made by a user gesture, which may or
may not be the case.

This CL plumbs the user gesture bit from the renderer to the browser
when PushManager.subscribe() is called. This means permission metrics
for push will now have the correct values recorded for the user gesture bit.

BUG=733483
==========

[commit-bot: I haz the power, 2017-06-15 08:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-15 08:41:17]

Dry run: This issue passed the CQ dry run.

[Peter Beverloo, 2017-06-15 13:46:05]

lgtm

[dominickn, 2017-06-15 22:37:20]

dominickn@chromium.org changed reviewers:
+ estark@chromium.org

[dominickn, 2017-06-15 22:37:21]

Thanks!

+estark for mojom security review

[dominickn, 2017-06-15 22:41:19]

dominickn@chromium.org changed reviewers:
+ kinuko@chromium.org

[dominickn, 2017-06-15 22:41:19]

Also +kinuko for content/public and content/child

[estark, 2017-06-16 05:07:14]

mojom lgtm

[kinuko, 2017-06-16 06:08:24]

lgtm

[dominickn, 2017-06-16 06:10:40]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2017-06-16 06:11:07]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-16 06:14:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1497593440678470,
"parent_rev": "2b36032776688471227ab1ebd9cb21faeb8e9bf4", "commit_rev":
"6ba3fa621ea462377f2d6f189ae1eb186f9cae16"}

[commit-bot: I haz the power, 2017-06-16 06:15:02]

Description was changed from

==========
Propagate the user gesture bit when requesting push messaging permission.

Currently, directly subscribing to push messages without having
previously been granted notifications permissions results in
a permission prompt to the user. This prompt is hardcoded to always tell
the permissions layer that it was made by a user gesture, which may or
may not be the case.

This CL plumbs the user gesture bit from the renderer to the browser
when PushManager.subscribe() is called. This means permission metrics
for push will now have the correct values recorded for the user gesture bit.

BUG=733483
==========

to

==========
Propagate the user gesture bit when requesting push messaging permission.

Currently, directly subscribing to push messages without having
previously been granted notifications permissions results in
a permission prompt to the user. This prompt is hardcoded to always tell
the permissions layer that it was made by a user gesture, which may or
may not be the case.

This CL plumbs the user gesture bit from the renderer to the browser
when PushManager.subscribe() is called. This means permission metrics
for push will now have the correct values recorded for the user gesture bit.

BUG=733483

Review-Url: https://codereview.chromium.org/2935333003
Cr-Commit-Position: refs/heads/master@{#479965}
Committed:
https://chromium.googlesource.com/chromium/src/+/6ba3fa621ea462377f2d6f189ae1...
==========

[commit-bot: I haz the power, 2017-06-16 06:15:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6ba3fa621ea462377f2d6f189ae1...