Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Side by Side Diff: chrome/browser/push_messaging/push_messaging_service_impl.h

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)
Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_IMPL_H_ 5 #ifndef CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_IMPL_H_
6 #define CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_IMPL_H_ 6 #define CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_IMPL_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 #include <memory> 9 #include <memory>
10 #include <set> 10 #include <set>
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 const std::string& message_id) override; 74 const std::string& message_id) override;
75 bool CanHandle(const std::string& app_id) const override; 75 bool CanHandle(const std::string& app_id) const override;
76 76
77 // content::PushMessagingService implementation: 77 // content::PushMessagingService implementation:
78 GURL GetEndpoint(bool standard_protocol) const override; 78 GURL GetEndpoint(bool standard_protocol) const override;
79 void SubscribeFromDocument(const GURL& requesting_origin, 79 void SubscribeFromDocument(const GURL& requesting_origin,
80 int64_t service_worker_registration_id, 80 int64_t service_worker_registration_id,
81 int renderer_id, 81 int renderer_id,
82 int render_frame_id, 82 int render_frame_id,
83 const content::PushSubscriptionOptions& options, 83 const content::PushSubscriptionOptions& options,
84 bool user_gesture,
84 const RegisterCallback& callback) override; 85 const RegisterCallback& callback) override;
85 void SubscribeFromWorker(const GURL& requesting_origin, 86 void SubscribeFromWorker(const GURL& requesting_origin,
86 int64_t service_worker_registration_id, 87 int64_t service_worker_registration_id,
87 const content::PushSubscriptionOptions& options, 88 const content::PushSubscriptionOptions& options,
88 const RegisterCallback& callback) override; 89 const RegisterCallback& callback) override;
89 void GetSubscriptionInfo(const GURL& origin, 90 void GetSubscriptionInfo(const GURL& origin,
90 int64_t service_worker_registration_id, 91 int64_t service_worker_registration_id,
91 const std::string& sender_id, 92 const std::string& sender_id,
92 const std::string& subscription_id, 93 const std::string& subscription_id,
93 const SubscriptionInfoCallback& callback) override; 94 const SubscriptionInfoCallback& callback) override;
(...skipping 198 matching lines...) Expand 10 before | Expand all | Expand 10 after
292 // True when shutdown has started. Do not allow processing of incoming 293 // True when shutdown has started. Do not allow processing of incoming
293 // messages when this is true. 294 // messages when this is true.
294 bool shutdown_started_ = false; 295 bool shutdown_started_ = false;
295 296
296 base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_; 297 base::WeakPtrFactory<PushMessagingServiceImpl> weak_factory_;
297 298
298 DISALLOW_COPY_AND_ASSIGN(PushMessagingServiceImpl); 299 DISALLOW_COPY_AND_ASSIGN(PushMessagingServiceImpl);
299 }; 300 };
300 301
301 #endif // CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_IMPL_H_ 302 #endif // CHROME_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_SERVICE_IMPL_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/push_messaging/push_messaging_service_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698