Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: content/browser/push_messaging/push_messaging_manager.h

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)
Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_MANAGER_H_ 5 #ifndef CONTENT_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_MANAGER_H_
6 #define CONTENT_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_MANAGER_H_ 6 #define CONTENT_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_MANAGER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <memory> 10 #include <memory>
(...skipping 28 matching lines...) Expand all
39 PushMessagingManager(int render_process_id, 39 PushMessagingManager(int render_process_id,
40 ServiceWorkerContextWrapper* service_worker_context); 40 ServiceWorkerContextWrapper* service_worker_context);
41 41
42 void BindRequest(const service_manager::BindSourceInfo& source_info, 42 void BindRequest(const service_manager::BindSourceInfo& source_info,
43 mojom::PushMessagingRequest request); 43 mojom::PushMessagingRequest request);
44 44
45 // mojom::PushMessaging impl, run on IO thread. 45 // mojom::PushMessaging impl, run on IO thread.
46 void Subscribe(int32_t render_frame_id, 46 void Subscribe(int32_t render_frame_id,
47 int64_t service_worker_registration_id, 47 int64_t service_worker_registration_id,
48 const PushSubscriptionOptions& options, 48 const PushSubscriptionOptions& options,
49 bool user_gesture,
49 SubscribeCallback callback) override; 50 SubscribeCallback callback) override;
50 void Unsubscribe(int64_t service_worker_registration_id, 51 void Unsubscribe(int64_t service_worker_registration_id,
51 UnsubscribeCallback callback) override; 52 UnsubscribeCallback callback) override;
52 void GetSubscription(int64_t service_worker_registration_id, 53 void GetSubscription(int64_t service_worker_registration_id,
53 GetSubscriptionCallback callback) override; 54 GetSubscriptionCallback callback) override;
54 void GetPermissionStatus(int64_t service_worker_registration_id, 55 void GetPermissionStatus(int64_t service_worker_registration_id,
55 bool user_visible, 56 bool user_visible,
56 GetPermissionStatusCallback callback) override; 57 GetPermissionStatusCallback callback) override;
57 58
58 private: 59 private:
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 mojo::BindingSet<mojom::PushMessaging> bindings_; 139 mojo::BindingSet<mojom::PushMessaging> bindings_;
139 140
140 base::WeakPtrFactory<PushMessagingManager> weak_factory_io_to_io_; 141 base::WeakPtrFactory<PushMessagingManager> weak_factory_io_to_io_;
141 142
142 DISALLOW_COPY_AND_ASSIGN(PushMessagingManager); 143 DISALLOW_COPY_AND_ASSIGN(PushMessagingManager);
143 }; 144 };
144 145
145 } // namespace content 146 } // namespace content
146 147
147 #endif // CONTENT_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_MANAGER_H_ 148 #endif // CONTENT_BROWSER_PUSH_MESSAGING_PUSH_MESSAGING_MANAGER_H_
OLDNEW
« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.cc ('k') | content/browser/push_messaging/push_messaging_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698