content/shell/browser/layout_test/layout_test_push_messaging_service.h - Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_push_messaging_service.h

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)

Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/push_messaging/push_messaging_client.cc ('k') | content/shell/browser/layout_test/layout_test_push_messaging_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_push_messaging_service.h

diff --git a/content/shell/browser/layout_test/layout_test_push_messaging_service.h b/content/shell/browser/layout_test/layout_test_push_messaging_service.h

index 536b3755679587b28ad2a96c4d7bba1a19ef654c..ef6cfb3d977ca7e038388d8a3901d7ee101bbd40 100644

--- a/content/shell/browser/layout_test/layout_test_push_messaging_service.h

+++ b/content/shell/browser/layout_test/layout_test_push_messaging_service.h

@@ -31,6 +31,7 @@ class LayoutTestPushMessagingService : public PushMessagingService {

int renderer_id,

int render_frame_id,

const PushSubscriptionOptions& options,

+ bool user_gesture,

const RegisterCallback& callback) override;

void SubscribeFromWorker(const GURL& requesting_origin,

int64_t service_worker_registration_id,