third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h - Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)

Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/push_messaging/PushManager.cpp ('k') | third_party/WebKit/public/platform/modules/push_messaging/WebPushProvider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

diff --git a/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h b/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

index da93df97b6b7d969d338bf79e90604168e745396..51f4f8d829079f1aeb7264b0a09781191a8cd3f9 100644

--- a/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

+++ b/third_party/WebKit/public/platform/modules/push_messaging/WebPushClient.h

@@ -23,6 +23,7 @@ class WebPushClient {

// Ownership of the callbacks is transferred to the client.

virtual void Subscribe(WebServiceWorkerRegistration*,

const WebPushSubscriptionOptions&,

+ bool user_gesture,

std::unique_ptr<WebPushSubscriptionCallbacks>) = 0;

};