Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7605)

Unified Diff: chrome/browser/push_messaging/push_messaging_service_impl.cc

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)
Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/push_messaging/push_messaging_service_impl.cc
diff --git a/chrome/browser/push_messaging/push_messaging_service_impl.cc b/chrome/browser/push_messaging/push_messaging_service_impl.cc
index b01f0aaf01091c9a27322bd4771c75819d559207..520be4f19ea48839d9b620798622044adb8c9279 100644
--- a/chrome/browser/push_messaging/push_messaging_service_impl.cc
+++ b/chrome/browser/push_messaging/push_messaging_service_impl.cc
@@ -451,6 +451,7 @@ void PushMessagingServiceImpl::SubscribeFromDocument(
int renderer_id,
int render_frame_id,
const content::PushSubscriptionOptions& options,
+ bool user_gesture,
const RegisterCallback& callback) {
PushMessagingAppIdentifier app_identifier =
PushMessagingAppIdentifier::Generate(requesting_origin,
@@ -482,7 +483,7 @@ void PushMessagingServiceImpl::SubscribeFromDocument(
// Push does not allow permission requests from iframes.
PermissionManager::Get(profile_)->RequestPermission(
CONTENT_SETTINGS_TYPE_PUSH_MESSAGING, web_contents->GetMainFrame(),
- requesting_origin, true /* user_gesture */,
+ requesting_origin, user_gesture,
base::Bind(&PushMessagingServiceImpl::DoSubscribe,
weak_factory_.GetWeakPtr(), app_identifier, options,
callback));
« no previous file with comments | « chrome/browser/push_messaging/push_messaging_service_impl.h ('k') | content/browser/push_messaging/push_messaging_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698