Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1761)

Unified Diff: content/renderer/push_messaging/push_messaging_client.h

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)
Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/push_messaging/push_messaging_client.h
diff --git a/content/renderer/push_messaging/push_messaging_client.h b/content/renderer/push_messaging/push_messaging_client.h
index e0a99fa17089ff6e1f2370730b18094aecff296f..695479e05f4a668c64524d19d6580d6e789a4570 100644
--- a/content/renderer/push_messaging/push_messaging_client.h
+++ b/content/renderer/push_messaging/push_messaging_client.h
@@ -44,11 +44,13 @@ class PushMessagingClient : public RenderFrameObserver,
void Subscribe(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
+ bool user_gesture,
std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks) override;
void DidGetManifest(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
+ bool user_gesture,
std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks,
const GURL& manifest_url,
const Manifest& manifest,
@@ -57,6 +59,7 @@ class PushMessagingClient : public RenderFrameObserver,
void DoSubscribe(
blink::WebServiceWorkerRegistration* service_worker_registration,
const PushSubscriptionOptions& options,
+ bool user_gesture,
std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks);
void DidSubscribe(
« no previous file with comments | « content/public/browser/push_messaging_service.h ('k') | content/renderer/push_messaging/push_messaging_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698