content/child/push_messaging/push_provider.h - Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/push_messaging/push_provider.h

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)

Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/push_messaging/push_provider.h

diff --git a/content/child/push_messaging/push_provider.h b/content/child/push_messaging/push_provider.h

index f9e823e20a2a5cc6dc47b143901915efadd144ee..6264fc185a664160815bfb207514c73d668b2dba 100644

--- a/content/child/push_messaging/push_provider.h

+++ b/content/child/push_messaging/push_provider.h

@@ -48,6 +48,7 @@ class PushProvider : public blink::WebPushProvider,

void Subscribe(

blink::WebServiceWorkerRegistration* service_worker_registration,

const blink::WebPushSubscriptionOptions& options,

+ bool user_gesture,

std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks) override;

void Unsubscribe(

blink::WebServiceWorkerRegistration* service_worker_registration,