content/common/push_messaging.mojom - Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/push_messaging.mojom

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)

Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/common/push_messaging.mojom

diff --git a/content/common/push_messaging.mojom b/content/common/push_messaging.mojom

index 6ec28f5d6e579a367b209240c1c186a570405868..94b0ea1f902aaf04cf6c86e0e098ef18a224592e 100644

--- a/content/common/push_messaging.mojom

+++ b/content/common/push_messaging.mojom

@@ -143,7 +143,8 @@ enum PushPermissionStatus {

interface PushMessaging {

Subscribe(int32 render_frame_id,

int64 service_worker_registration_id,

- PushSubscriptionOptions options)

+ PushSubscriptionOptions options,

+ bool user_gesture)

=> (PushRegistrationStatus status,

url.mojom.Url? endpoint,

PushSubscriptionOptions? options,