Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: content/child/push_messaging/push_provider.cc

Issue 2935333003: Propagate the user gesture bit when requesting push messaging permission. (Closed)
Patch Set: ThreadSafe user gesture check Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/child/push_messaging/push_provider.h ('k') | content/common/push_messaging.mojom » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/push_messaging/push_provider.cc
diff --git a/content/child/push_messaging/push_provider.cc b/content/child/push_messaging/push_provider.cc
index adcc0eb35a451aa15e4b57d8c6ef151e893b5342..54761ccba226a0f86d1050b5e021d5f300fa01b0 100644
--- a/content/child/push_messaging/push_provider.cc
+++ b/content/child/push_messaging/push_provider.cc
@@ -121,6 +121,7 @@ void PushProvider::WillStopCurrentWorkerThread() {
void PushProvider::Subscribe(
blink::WebServiceWorkerRegistration* service_worker_registration,
const blink::WebPushSubscriptionOptions& options,
+ bool user_gesture,
std::unique_ptr<blink::WebPushSubscriptionCallbacks> callbacks) {
DCHECK(service_worker_registration);
DCHECK(callbacks);
@@ -136,7 +137,7 @@ void PushProvider::Subscribe(
push_messaging_manager_->Subscribe(
ChildProcessHost::kInvalidUniqueID, service_worker_registration_id,
- content_options,
+ content_options, user_gesture,
// Safe to use base::Unretained because |push_messaging_manager_ |is owned
// by |this|.
base::Bind(&PushProvider::DidSubscribe, base::Unretained(this),
« no previous file with comments | « content/child/push_messaging/push_provider.h ('k') | content/common/push_messaging.mojom » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698