Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)

Created:
3 years, 7 months ago by hugoh_UTC2
Modified:
3 years, 5 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, imcheng+watch_chromium.org, tfarina, feature-media-reviews_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, mfoltz+watch_chromium.org, pfeldman, Devlin
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow generation of a chromium outdirs when enable_extensions=false This allows us at Opera to patch chromium a little less before building a downstream product that doesn't depend on extensions. At the moment, the 'chrome' target does not compile when enable_extensions=false - and this is fine since Chrome indeed needs extensions. But other browser products that use enable_extensions=false can now generate an outdir without getting complaints from GN. BUG=725906 TEST=gn gen out/GnTest TEST=gn gen --args='enable_extensions=false' out/GnTest TEST=gn gen --args='is_component_build=true' out/GnTest TEST=gn gen --args='is_component_build=true enable_extensions=false' out/GnTest TEST=gn gen --args='target_os="android"' out/GnTest TEST=gn gen --args='target_os="android" enable_extensions=false' out/GnTest TEST=gn gen --args='target_os="chromeos"' out/GnTest TEST=gn gen --args='target_os="chromeos" is_component_build=true' out/GnTest Review-Url: https://codereview.chromium.org/2904443004 Cr-Commit-Position: refs/heads/master@{#479646} Committed: https://chromium.googlesource.com/chromium/src/+/f7a620c87d8df98cbf01a6775c668768d0cd4840

Patch Set 1 #

Patch Set 2 : Fix error from "gn gen out --check" #

Total comments: 9

Patch Set 3 : Add assert(enable_extensions) to apps/BUILD.gn and fixup chrome/browser/media/router/BUILD.gn #

Total comments: 2

Patch Set 4 : Rebase and address comment in src/BUILD.gn #

Total comments: 4

Patch Set 5 : Addressed michaelpg's comments #

Patch Set 6 : Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) #

Total comments: 12

Patch Set 7 : Fixed Devlin's comments #

Patch Set 8 : Rebase #

Patch Set 9 : Missed to fix one of Devlin's comments #

Patch Set 10 : Refix sources -= [ ... ] #

Patch Set 11 : Rebase and add assert to extensions/shell/installer/linux/BUILD.gn #

Patch Set 12 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+365 lines, -47 lines) Patch
M apps/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +34 lines, -34 lines 0 comments Download
M chrome/browser/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 2 3 4 5 6 3 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/media/router/BUILD.gn View 1 2 3 4 5 6 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 2 chunks +8 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 4 chunks +12 lines, -6 lines 0 comments Download
M extensions/browser/api/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/api/activity_log/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/alarms/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/app_current_window_internal/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/app_runtime/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/app_window/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/audio/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/bluetooth/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/bluetooth_low_energy/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/cast_channel/BUILD.gn View 1 2 3 4 5 6 7 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/clipboard/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/declarative/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/declarative_content/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/diagnostics/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/display_source/BUILD.gn View 1 2 3 4 5 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/browser/api/dns/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/document_scan/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/file_handlers/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/hid/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/idle/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/management/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/messaging/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/metrics_private/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/mime_handler_private/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/networking_config/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/networking_private/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/power/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/printer_provider/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/printer_provider_internal/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/runtime/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/serial/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/socket/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/sockets_tcp/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/sockets_udp/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/storage/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/system_cpu/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/system_display/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/system_info/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/system_memory/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/system_network/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/system_storage/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/test/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/usb/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/virtual_keyboard/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/virtual_keyboard_private/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/vpn_provider/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/web_request/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/api/webcam_private/BUILD.gn View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/browser/app_window/BUILD.gn View 1 2 3 4 5 6 7 8 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/guest_view/web_view/web_ui/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/install/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/kiosk/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/updater/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/browser/value_store/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/common/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/components/javascript_dialog_extensions_client/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/components/native_app_window/BUILD.gn View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M extensions/features/BUILD.gn View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/shell/common/api/BUILD.gn View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M extensions/shell/installer/linux/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 74 (37 generated)
hugoh_UTC2
michaelpg@ PTAL dpranke@ since you already approved this idea (we upstreamed this in https://codereview.chromium.org/1950003002/), I ...
3 years, 7 months ago (2017-05-23 12:06:38 UTC) #2
Nico
> We need an upstream buildbot that checks that these build configurations; I'm pretty sure ...
3 years, 7 months ago (2017-05-23 14:35:03 UTC) #13
hugoh_UTC2
On 2017/05/23 14:35:03, Nico wrote: > > We need an upstream buildbot that checks that ...
3 years, 7 months ago (2017-05-23 15:16:34 UTC) #14
michaelpg
(dpranke: Correct me if I'm imbuing .gn files with meaning they aren't meant to have.) ...
3 years, 7 months ago (2017-05-23 16:54:40 UTC) #15
michaelpg
Also, crbug.com/641155 is not directly relevant to this CL. Maybe open a new bug for ...
3 years, 7 months ago (2017-05-23 16:57:00 UTC) #16
Mostyn Bramley-Moore
IMO, to do this cleanly would require: 1) move targets like chromium that depend on ...
3 years, 7 months ago (2017-05-23 17:46:59 UTC) #17
Dirk Pranke
+brettw ... I think there's two different questions here. The first is, do we want ...
3 years, 7 months ago (2017-05-23 20:00:11 UTC) #19
hugoh_UTC2
https://codereview.chromium.org/2904443004/diff/20001/apps/BUILD.gn File apps/BUILD.gn (right): https://codereview.chromium.org/2904443004/diff/20001/apps/BUILD.gn#newcode11 apps/BUILD.gn:11: static_library("apps") { On 2017/05/23 20:00:11, Dirk Pranke (slow) wrote: ...
3 years, 7 months ago (2017-05-24 13:58:06 UTC) #20
Dirk Pranke
To repeat my earlier question, in case you missed it: Can we get to a ...
3 years, 7 months ago (2017-05-24 16:44:00 UTC) #22
Mostyn Bramley-Moore
On 2017/05/24 16:44:00, Dirk Pranke (slow) wrote: > To repeat my earlier question, in case ...
3 years, 7 months ago (2017-05-24 16:57:42 UTC) #23
hugoh_UTC2
On 2017/05/24 16:57:42, Mostyn Bramley-Moore wrote: > On 2017/05/24 16:44:00, Dirk Pranke (slow) wrote: > ...
3 years, 7 months ago (2017-05-26 14:25:18 UTC) #24
Dirk Pranke
On 2017/05/26 14:25:18, hugoh_UTC2 wrote: > On 2017/05/24 16:57:42, Mostyn Bramley-Moore wrote: > > On ...
3 years, 6 months ago (2017-06-07 20:15:10 UTC) #25
hugoh_UTC2
https://codereview.chromium.org/2904443004/diff/40001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2904443004/diff/40001/BUILD.gn#newcode156 BUILD.gn:156: } On 2017/05/24 16:44:00, Dirk Pranke wrote: > Can ...
3 years, 6 months ago (2017-06-08 12:07:21 UTC) #28
hugoh_UTC2
On 2017/06/07 20:15:10, Dirk Pranke wrote: > On 2017/05/26 14:25:18, hugoh_UTC2 wrote: > > On ...
3 years, 6 months ago (2017-06-08 12:07:56 UTC) #29
Dirk Pranke
lgtm if you file a follow-up bug to clean up the dependencies elsewhere in the ...
3 years, 6 months ago (2017-06-08 21:19:08 UTC) #30
michaelpg
Devlin, can you take a look too? https://codereview.chromium.org/2904443004/diff/80001/apps/BUILD.gn File apps/BUILD.gn (right): https://codereview.chromium.org/2904443004/diff/80001/apps/BUILD.gn#newcode15 apps/BUILD.gn:15: if (enable_extensions) ...
3 years, 6 months ago (2017-06-08 22:54:41 UTC) #32
hugoh_UTC2
https://codereview.chromium.org/2904443004/diff/80001/apps/BUILD.gn File apps/BUILD.gn (right): https://codereview.chromium.org/2904443004/diff/80001/apps/BUILD.gn#newcode15 apps/BUILD.gn:15: if (enable_extensions) { On 2017/06/08 22:54:41, michaelpg wrote: > ...
3 years, 6 months ago (2017-06-09 09:25:42 UTC) #34
hugoh_UTC2
On 2017/06/08 21:19:08, Dirk Pranke wrote: > lgtm if you file a follow-up bug to ...
3 years, 6 months ago (2017-06-09 12:49:46 UTC) #35
michaelpg
note: you'll want to rebase on https://codereview.chromium.org/2905153003
3 years, 6 months ago (2017-06-09 16:45:40 UTC) #36
Devlin
https://codereview.chromium.org/2904443004/diff/140001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2904443004/diff/140001/BUILD.gn#newcode214 BUILD.gn:214: deps += [ "//extensions/shell:app_shell_unittests" ] nit: combine these enable_extension ...
3 years, 6 months ago (2017-06-09 19:11:52 UTC) #37
hugoh_UTC2
I've fixed Devlin's comments and rebased again. PTAL. https://codereview.chromium.org/2904443004/diff/140001/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/2904443004/diff/140001/BUILD.gn#newcode214 BUILD.gn:214: deps ...
3 years, 6 months ago (2017-06-12 09:19:08 UTC) #38
Devlin
lgtm; thank you for the cleanup!
3 years, 6 months ago (2017-06-12 15:04:50 UTC) #39
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904443004/200001
3 years, 6 months ago (2017-06-12 15:23:13 UTC) #44
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/114997)
3 years, 6 months ago (2017-06-12 15:31:59 UTC) #46
hugoh_UTC2
benwells@, could you approve apps/BUILD.gn and maybe also extensions/browser/guest_view/extension_view/whitelist/BUILD.gn ? Missing LGTM from an OWNER ...
3 years, 6 months ago (2017-06-12 16:24:07 UTC) #50
pfeldman
devtools lgtm
3 years, 6 months ago (2017-06-12 16:50:19 UTC) #51
imcheng
chrome/browser/media/router/BUILD.gn lgtm
3 years, 6 months ago (2017-06-12 17:53:55 UTC) #54
benwells
lgtm
3 years, 6 months ago (2017-06-13 02:42:28 UTC) #55
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904443004/240001
3 years, 6 months ago (2017-06-13 07:18:48 UTC) #58
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/462173)
3 years, 6 months ago (2017-06-13 07:29:12 UTC) #60
hugoh_UTC2
Missing LGTM from an OWNER for these files: extensions/browser/guest_view/extension_view/whitelist/BUILD.gn brettw@ could you approve extensions/browser/guest_view/extension_view/whitelist/BUILD.gn ? ...
3 years, 6 months ago (2017-06-13 08:34:01 UTC) #61
brettw
whitelist LGTM
3 years, 6 months ago (2017-06-14 19:17:06 UTC) #62
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904443004/240001
3 years, 6 months ago (2017-06-14 20:38:46 UTC) #64
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/232018) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 6 months ago (2017-06-14 20:41:45 UTC) #66
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2904443004/260001
3 years, 6 months ago (2017-06-15 07:28:30 UTC) #69
commit-bot: I haz the power
Committed patchset #12 (id:260001) as https://chromium.googlesource.com/chromium/src/+/f7a620c87d8df98cbf01a6775c668768d0cd4840
3 years, 6 months ago (2017-06-15 09:00:35 UTC) #72
ashleymarie1
3 years, 6 months ago (2017-06-15 15:21:22 UTC) #73
Message was sent while issue was closed.
On 2017/06/15 09:00:35, commit-bot: I haz the power wrote:
> Committed patchset #12 (id:260001) as
>
https://chromium.googlesource.com/chromium/src/+/f7a620c87d8df98cbf01a6775c66...

Looks like it may have broke something:
https://bugs.chromium.org/p/chromium/issues/detail?id=733663&can=2&start=0&nu...

Powered by Google App Engine
This is Rietveld 408576698