Allow generation of a chromium outdirs when enable_extensions=false

chrome/browser/media/router/BUILD.gn

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 
+import("//extensions/features/features.gni")
 import("//testing/test.gni")
 
 static_library("router") {
   deps = [
     "//base",
     "//chrome/common:constants",
     "//components/keyed_service/content",
     "//components/keyed_service/core",
     "//content/public/browser",
     "//content/public/common",
@@ skipping 43 matching lines @@
     "receiver_presentation_service_delegate_impl.cc",
     "receiver_presentation_service_delegate_impl.h",
     "render_frame_host_id.h",
     "route_message_observer.cc",
     "route_message_observer.h",
   ]
 
   if (!is_android) {
     deps += [
       "discovery",
       "//extensions/browser",

[michaelpg, 2017/05/23 16:54:40]

What about this? (!enable_extensions should not apply is_android, right?)

[hugoh_UTC2, 2017/05/24 13:58:06]

True. In PS3 I moved the check for enable_extensions earlier up so we check both
conditions. (Just because we're not on Android, we can't assume that extensions
are enabled.)

       "//mojo/public/cpp/bindings",
     ]
     sources += [
       # TODO(crbug.com/646627): Move media_router_ui_service* to
       # chrome/browser/ui/.
       "media_router_ui_service.cc",
       "media_router_ui_service.h",
       "media_router_ui_service_factory.cc",
       "media_router_ui_service_factory.h",
       "mojo/media_route_provider_util_win.cc",
@@ skipping 19 matching lines @@
     "mock_screen_availability_listener.cc",
     "mock_screen_availability_listener.h",
     "test_helper.cc",
     "test_helper.h",
   ]
 
   if (!is_android) {
     deps += [
       "//chrome/common/media_router/mojo:media_router",
       "//chrome/common/media_router/mojo:media_router_test_interfaces",
-      "//extensions/common",
     ]
+    if (enable_extensions) {
+      deps += [ "//extensions/common" ]

[michaelpg, 2017/05/23 16:54:40]

media-router sources unconditionally include files from extensions/common.
Either the tests target shouldn't exist if !enable_extensions, or... this kind
of defeats the purpose of deps, I think.

[hugoh_UTC2, 2017/05/24 13:58:06]

When !is_android, static_library("test_support") should only depend on
extensions if extensions_enabled? (But this test target should still exist?)

+    }
     sources += [
       "discovery/mdns/mock_dns_sd_registry.cc",
       "discovery/mdns/mock_dns_sd_registry.h",
       "mojo/media_router_mojo_test.cc",
       "mojo/media_router_mojo_test.h",
     ]
   }
 }