Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2905153003: Guard some extensions build rules with enable_extensions. (Closed)

Created:
3 years, 7 months ago by Lei Zhang
Modified:
3 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Guard some extensions build rules with enable_extensions. Review-Url: https://codereview.chromium.org/2905153003 Cr-Commit-Position: refs/heads/master@{#478122} Committed: https://chromium.googlesource.com/chromium/src/+/344fe3f3a731f0580069ea7e76afe0567bc22cfc

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+199 lines, -197 lines) Patch
M BUILD.gn View 1 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/test/BUILD.gn View 1 7 chunks +194 lines, -194 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Lei Zhang
3 years, 6 months ago (2017-05-26 17:20:58 UTC) #6
Dirk Pranke
lgtm, although I feel like I reviewed another CL that did something along these lines ...
3 years, 6 months ago (2017-06-07 19:59:59 UTC) #7
Lei Zhang
On 2017/06/07 19:59:59, Dirk Pranke (slow) wrote: > lgtm, although I feel like I reviewed ...
3 years, 6 months ago (2017-06-07 20:16:28 UTC) #8
Lei Zhang
On 2017/06/07 20:16:28, Lei Zhang wrote: > On 2017/06/07 19:59:59, Dirk Pranke (slow) wrote: > ...
3 years, 6 months ago (2017-06-08 21:11:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2905153003/20001
3 years, 6 months ago (2017-06-08 23:37:05 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/344fe3f3a731f0580069ea7e76afe0567bc22cfc
3 years, 6 months ago (2017-06-08 23:42:27 UTC) #19
michaelpg
3 years, 6 months ago (2017-06-09 16:46:36 UTC) #20
Message was sent while issue was closed.
On 2017/06/08 21:11:17, Lei Zhang wrote:
> On 2017/06/07 20:16:28, Lei Zhang wrote:
> > On 2017/06/07 19:59:59, Dirk Pranke (slow) wrote:
> > > lgtm, although I feel like I reviewed another CL that did something along
> > these
> > > lines recently, so there might be a merge conflict?
> > 
> > I'll check when I rebase.
> 
> Only conflicted in chrome/test/BUILD.gn due to test files being added/removed.

There's also https://codereview.chromium.org/2904443004 (which hasn't landed
yet)

Powered by Google App Engine
This is Rietveld 408576698