Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: chrome/browser/media/router/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 # 4 #
5 5
6 import("//extensions/features/features.gni")
6 import("//testing/test.gni") 7 import("//testing/test.gni")
7 8
8 static_library("router") { 9 static_library("router") {
9 deps = [ 10 deps = [
10 "//base", 11 "//base",
11 "//chrome/common:constants", 12 "//chrome/common:constants",
12 "//components/keyed_service/content", 13 "//components/keyed_service/content",
13 "//components/keyed_service/core", 14 "//components/keyed_service/core",
14 "//content/public/browser", 15 "//content/public/browser",
15 "//content/public/common", 16 "//content/public/common",
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
56 "presentation_service_delegate_impl.h", 57 "presentation_service_delegate_impl.h",
57 "presentation_service_delegate_observers.cc", 58 "presentation_service_delegate_observers.cc",
58 "presentation_service_delegate_observers.h", 59 "presentation_service_delegate_observers.h",
59 "receiver_presentation_service_delegate_impl.cc", 60 "receiver_presentation_service_delegate_impl.cc",
60 "receiver_presentation_service_delegate_impl.h", 61 "receiver_presentation_service_delegate_impl.h",
61 "render_frame_host_id.h", 62 "render_frame_host_id.h",
62 "route_message_observer.cc", 63 "route_message_observer.cc",
63 "route_message_observer.h", 64 "route_message_observer.h",
64 ] 65 ]
65 66
66 if (!is_android) { 67 if (!is_android && enable_extensions) {
Devlin 2017/06/09 19:11:52 ditto here and line 106 - probably just want an if
hugoh_UTC2 2017/06/12 09:19:08 Done.
67 deps += [ 68 deps += [
68 "discovery", 69 "discovery",
69 "//extensions/browser", 70 "//extensions/browser",
70 "//mojo/public/cpp/bindings", 71 "//mojo/public/cpp/bindings",
71 ] 72 ]
72 sources += [ 73 sources += [
73 # TODO(crbug.com/646627): Move media_router_ui_service* to 74 # TODO(crbug.com/646627): Move media_router_ui_service* to
74 # chrome/browser/ui/. 75 # chrome/browser/ui/.
75 "media_router_ui_service.cc", 76 "media_router_ui_service.cc",
76 "media_router_ui_service.h", 77 "media_router_ui_service.h",
(...skipping 18 matching lines...) Expand all
95 ] 96 ]
96 sources = [ 97 sources = [
97 "mock_media_router.cc", 98 "mock_media_router.cc",
98 "mock_media_router.h", 99 "mock_media_router.h",
99 "mock_screen_availability_listener.cc", 100 "mock_screen_availability_listener.cc",
100 "mock_screen_availability_listener.h", 101 "mock_screen_availability_listener.h",
101 "test_helper.cc", 102 "test_helper.cc",
102 "test_helper.h", 103 "test_helper.h",
103 ] 104 ]
104 105
105 if (!is_android) { 106 if (!is_android && enable_extensions) {
106 deps += [ 107 deps += [
107 "//chrome/common/media_router/mojo:media_router", 108 "//chrome/common/media_router/mojo:media_router",
108 "//chrome/common/media_router/mojo:media_router_test_interfaces", 109 "//chrome/common/media_router/mojo:media_router_test_interfaces",
109 "//extensions/common", 110 "//extensions/common",
110 ] 111 ]
111 sources += [ 112 sources += [
112 "discovery/mdns/mock_dns_sd_registry.cc", 113 "discovery/mdns/mock_dns_sd_registry.cc",
113 "discovery/mdns/mock_dns_sd_registry.h", 114 "discovery/mdns/mock_dns_sd_registry.h",
114 "mojo/media_router_mojo_test.cc", 115 "mojo/media_router_mojo_test.cc",
115 "mojo/media_router_mojo_test.h", 116 "mojo/media_router_mojo_test.h",
116 ] 117 ]
117 } 118 }
118 } 119 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698