 Chromium Code Reviews
 Chromium Code Reviews Issue 2904443004:
  Allow generation of a chromium outdirs when enable_extensions=false  (Closed)
    
  
    Issue 2904443004:
  Allow generation of a chromium outdirs when enable_extensions=false  (Closed) 
  | OLD | NEW | 
|---|---|
| 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 import("//extensions/features/features.gni") | |
| 6 | |
| 7 assert(enable_extensions, | |
| 8 "Cannot depend on extensions because enable_extensions=false.") | |
| 9 | |
| 5 source_set("app_window") { | 10 source_set("app_window") { | 
| 6 sources = [ | 11 sources = [ | 
| 7 "app_delegate.h", | 12 "app_delegate.h", | 
| 8 "app_web_contents_helper.cc", | 13 "app_web_contents_helper.cc", | 
| 9 "app_web_contents_helper.h", | 14 "app_web_contents_helper.h", | 
| 10 "app_window.cc", | 15 "app_window.cc", | 
| 11 "app_window.h", | 16 "app_window.h", | 
| 12 "app_window_client.cc", | 17 "app_window_client.cc", | 
| 13 "app_window_client.h", | 18 "app_window_client.h", | 
| 14 "app_window_contents.cc", | 19 "app_window_contents.cc", | 
| 15 "app_window_contents.h", | 20 "app_window_contents.h", | 
| 16 "app_window_geometry_cache.cc", | 21 "app_window_geometry_cache.cc", | 
| 17 "app_window_geometry_cache.h", | 22 "app_window_geometry_cache.h", | 
| 18 "app_window_registry.cc", | 23 "app_window_registry.cc", | 
| 19 "app_window_registry.h", | 24 "app_window_registry.h", | 
| 20 "native_app_window.h", | 25 "native_app_window.h", | 
| 21 "size_constraints.cc", | 26 "size_constraints.cc", | 
| 22 "size_constraints.h", | 27 "size_constraints.h", | 
| 23 ] | 28 ] | 
| 24 | 29 | 
| 25 configs += [ | 30 configs += [ | 
| 26 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. | 31 # TODO(jschuh): crbug.com/167187 fix size_t to int truncations. | 
| 27 "//build/config/compiler:no_size_t_to_int_warning", | 32 "//build/config/compiler:no_size_t_to_int_warning", | 
| 28 ] | 33 ] | 
| 29 | 34 | 
| 30 deps = [ | 35 deps = [ | 
| 31 "//content/public/common", | 36 "//content/public/common", | 
| 32 "//extensions:extensions_browser_resources", | |
| 33 "//extensions/strings", | |
| 34 ] | 37 ] | 
| 38 | |
| 39 if (enable_extensions) { | |
| 
Devlin
2017/06/09 19:11:52
here, too, why this block with the assert?
 
hugoh_UTC2
2017/06/12 09:19:08
Done. You're right.
 | |
| 40 deps += [ | |
| 41 "//extensions:extensions_browser_resources", | |
| 42 "//extensions/strings", | |
| 43 ] | |
| 44 } | |
| 35 } | 45 } | 
| OLD | NEW |