Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | apps/BUILD.gn » ('j') | chrome/browser/BUILD.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
85 if (!is_fuchsia) { 85 if (!is_fuchsia) {
86 deps += [ 86 deps += [
87 "//components:components_unittests", 87 "//components:components_unittests",
88 "//skia:skia_unittests", 88 "//skia:skia_unittests",
89 "//tools/metrics:metrics_metadata", 89 "//tools/metrics:metrics_metadata",
90 "//ui/base:ui_base_unittests", 90 "//ui/base:ui_base_unittests",
91 "//ui/gfx:gfx_unittests", 91 "//ui/gfx:gfx_unittests",
92 ] 92 ]
93 } 93 }
94 94
95 if (enable_extensions) {
96 deps += [
97 "//extensions:extensions_browsertests",
98 "//extensions:extensions_unittests",
99 ]
100 }
101
95 if (!is_ios && !is_android && !is_chromecast && !is_fuchsia) { 102 if (!is_ios && !is_android && !is_chromecast && !is_fuchsia) {
96 deps += [ 103 deps += [
97 "//chrome", 104 "//chrome",
98 "//chrome/test:browser_tests", 105 "//chrome/test:browser_tests",
99 "//chrome/test:interactive_ui_tests", 106 "//chrome/test:interactive_ui_tests",
100 "//chrome/test:sync_integration_tests", 107 "//chrome/test:sync_integration_tests",
101 "//chrome/test/chromedriver:chromedriver_unittests", 108 "//chrome/test/chromedriver:chromedriver_unittests",
102 "//components/sync/tools:sync_client", 109 "//components/sync/tools:sync_client",
103 "//components/sync/tools:sync_listen_notifications", 110 "//components/sync/tools:sync_listen_notifications",
104 "//extensions:extensions_browsertests",
105 "//extensions:extensions_unittests",
106 "//gpu/gles2_conform_support:gles2_conform_test", 111 "//gpu/gles2_conform_support:gles2_conform_test",
107 "//gpu/khronos_glcts_support:khronos_glcts_test", 112 "//gpu/khronos_glcts_support:khronos_glcts_test",
108 "//jingle:jingle_unittests", 113 "//jingle:jingle_unittests",
109 "//net:hpack_example_generator", 114 "//net:hpack_example_generator",
110 "//ppapi:ppapi_unittests", 115 "//ppapi:ppapi_unittests",
111 "//ppapi/examples/2d", 116 "//ppapi/examples/2d",
112 "//ppapi/examples/audio", 117 "//ppapi/examples/audio",
113 "//ppapi/examples/audio_input", 118 "//ppapi/examples/audio_input",
114 "//ppapi/examples/compositor", 119 "//ppapi/examples/compositor",
115 "//ppapi/examples/crxfs", 120 "//ppapi/examples/crxfs",
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
199 "//url/ipc:url_ipc_unittests", 204 "//url/ipc:url_ipc_unittests",
200 "//v8:gn_all", 205 "//v8:gn_all",
201 ] 206 ]
202 } else if (is_ios) { 207 } else if (is_ios) {
203 deps += [ "//ios:all" ] 208 deps += [ "//ios:all" ]
204 } 209 }
205 210
206 deps += root_extra_deps 211 deps += root_extra_deps
207 212
208 if (enable_extensions) { 213 if (enable_extensions) {
209 deps += [ "//extensions/shell:app_shell_unittests" ] 214 deps += [ "//extensions/shell:app_shell_unittests" ]
Devlin 2017/06/09 19:11:51 nit: combine these enable_extension blocks?
hugoh_UTC2 2017/06/12 09:19:08 Done.
210 } 215 }
211 216
212 if (enable_remoting) { 217 if (enable_remoting) {
213 deps += [ "//remoting:remoting_all" ] 218 deps += [ "//remoting:remoting_all" ]
214 } 219 }
215 220
216 if (toolkit_views) { 221 if (toolkit_views) {
217 deps += [ 222 deps += [
218 "//ui/views:views_unittests", 223 "//ui/views:views_unittests",
219 "//ui/views/examples:views_examples_exe", 224 "//ui/views/examples:views_examples_exe",
(...skipping 830 matching lines...) Expand 10 before | Expand all | Expand 10 after
1050 assert(target_name != "") # Mark as used. 1055 assert(target_name != "") # Mark as used.
1051 sources = invoker.actual_sources 1056 sources = invoker.actual_sources
1052 assert( 1057 assert(
1053 sources == invoker.actual_sources, 1058 sources == invoker.actual_sources,
1054 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1059 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1055 } 1060 }
1056 1061
1057 assert_valid_out_dir("_unused") { 1062 assert_valid_out_dir("_unused") {
1058 actual_sources = [ "$root_build_dir/foo" ] 1063 actual_sources = [ "$root_build_dir/foo" ]
1059 } 1064 }
OLDNEW
« no previous file with comments | « no previous file | apps/BUILD.gn » ('j') | chrome/browser/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698