Allow generation of a chromium outdirs when enable_extensions=false

extensions/browser/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/features.gni")
 import("//extensions/features/features.gni")
 
 group("browser") {
-  public_deps = [
-    "//extensions/browser:browser_context_keyed_service_factories",
-    "//extensions/browser:browser_sources",
-    "//extensions/browser/api:api_registration",
-  ]
-
   if (enable_extensions) {
     # Includes all API implementations and the ExtensionsApiClient
     # interface. Moving an API from src/chrome to src/extensions implies
     # it can be cleanly disabled with enable_extensions=false.
     # TODO: Eventually the entire extensions module should not be built
     # when enable_extensions=false.
-    public_deps += [ "//extensions/browser/api" ]
+    public_deps = [

[Dirk Pranke, 2017/05/23 20:00:11]

How feasible is it to make it so that nothing under //extensions is getting
included if enable_extensions is false?

i.e., can we get to a point where all //extensions/* BUILD files have
assert(enable_extensions) at the top?

+      "//extensions/browser:browser_context_keyed_service_factories",
+      "//extensions/browser:browser_sources",
+      "//extensions/browser/api",
+      "//extensions/browser/api:api_registration",
+    ]
   }
 }
 
 # Isolate the instantiation of BrowserContextKeyedServiceFactories.
 source_set("browser_context_keyed_service_factories") {
   visibility = [ ":*" ]
 
   sources = [
     "browser_context_keyed_service_factories.cc",
     "browser_context_keyed_service_factories.h",
@@ skipping 19 matching lines @@
     "//components/pref_registry",
     "//components/sessions",
     "//components/update_client",
     "//components/version_info",
     "//components/web_cache/browser",
     "//components/web_modal",
     "//components/zoom",
     "//content/public/browser",
     "//content/public/common",
     "//crypto:platform",
-    "//extensions/common",
-    "//extensions/common/api",
-    "//extensions/features",
-    "//extensions/strings",
     "//google_apis",
     "//ui/display",
   ]
 
+  if (enable_extensions) {
+    deps += [
+      "//extensions/common",
+      "//extensions/common/api",
+      "//extensions/features",
+      "//extensions/strings",
+    ]
+  }
+
   configs += [
     "//build/config:precompiled_headers",
 
     # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
     "//build/config/compiler:no_size_t_to_int_warning",
   ]
 
   if (enable_extensions) {
     sources = [
       "api_activity_monitor.cc",
@@ skipping 270 matching lines @@
   deps = [
     ":browser",
     "//base",
     "//components/guest_view/browser:test_support",
     "//components/storage_monitor:test_support",
     "//content/test:test_support",
     "//device/base:mocks",
     "//device/bluetooth:mocks",
     "//device/hid:mocks",
     "//device/usb:test_support",
-    "//extensions:test_support",
-    "//extensions/common",
-    "//extensions/common/api",
-    "//extensions/shell:app_shell_lib",
-    "//extensions/shell:browser_tests",
     "//net:test_support",
   ]
 
+  if (enable_extensions) {
+    deps += [
+      "//extensions:test_support",
+      "//extensions/common",
+      "//extensions/common/api",
+      "//extensions/shell:app_shell_lib",
+      "//extensions/shell:browser_tests",
+    ]
+  }
+
   if (is_mac) {
     # Needed for App Shell.app's Helper.
     deps += [ "//extensions/shell:app_shell" ]
   }
   if (is_chromeos) {
     sources += [ "api/virtual_keyboard/virtual_keyboard_apitest.cc" ]
 
     deps += [ "//chromeos" ]
   }
 }
 
 source_set("test_support") {
   testonly = true
   sources = [
     "preload_check_test_util.cc",
     "preload_check_test_util.h",
   ]
 
   deps = [
     "//base",
-    "//extensions/browser",
-    "//extensions/common",
     "//testing/gtest",
   ]
+
+  if (enable_extensions) {
+    deps += [
+      "//extensions/browser",
+      "//extensions/common",
+    ]
+  }
 }
 
 source_set("unit_tests") {
   testonly = true
   sources = [
     "api/alarms/alarms_api_unittest.cc",
     "api/api_resource_manager_unittest.cc",
     "api/bluetooth/bluetooth_event_router_unittest.cc",
     "api/cast_channel/cast_auth_util_unittest.cc",
     "api/cast_channel/cast_channel_api_unittest.cc",
@@ skipping 88 matching lines @@
     "//components/onc",
     "//components/pref_registry:pref_registry",
     "//components/prefs:test_support",
     "//components/sync_preferences:test_support",
     "//components/update_client",
     "//components/url_matcher",
     "//components/user_prefs",
     "//content/test:test_support",
     "//device/bluetooth:mocks",
     "//device/power_save_blocker",
-    "//extensions:extensions_browser_resources",
-    "//extensions:test_support",
-    "//extensions/common",
-    "//extensions/common/api",
-    "//extensions/features",
     "//ipc:test_support",
     "//net:test_support",
     "//storage/browser:test_support",
     "//third_party/leveldatabase",
     "//third_party/zlib/google:zip",
   ]
 
+  if (enable_extensions) {
+    deps += [
+      "//extensions:extensions_browser_resources",
+      "//extensions:test_support",
+      "//extensions/common",
+      "//extensions/common/api",
+      "//extensions/features",
+    ]
+  }
+
   if (is_chromeos) {
     sources += [
       "api/audio/audio_device_id_calculator_unittest.cc",
       "api/webcam_private/visca_webcam_unittest.cc",
     ]
 
     deps += [ "//chromeos:test_support" ]
   }
 }