Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: apps/ui/views/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Rebase and address comment in src/BUILD.gn Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2017 The Chromium Authors. All rights reserved. 1 # Copyright 2017 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//extensions/features/features.gni") 6 import("//extensions/features/features.gni")
7 7
8 assert(enable_extensions)
9
10 source_set("views") { 8 source_set("views") {
michaelpg 2017/06/08 22:54:41 this shouldn't be built if (!enable_extensions) ca
hugoh_UTC2 2017/06/09 09:25:42 You're right. Problem was that chrome/browser/ui/B
11 sources = [ 9 sources = [
12 "app_window_frame_view.cc", 10 "app_window_frame_view.cc",
13 "app_window_frame_view.h", 11 "app_window_frame_view.h",
14 ] 12 ]
15 13
16 deps = [ 14 deps = [
17 "//cc/paint", 15 "//cc/paint",
18 "//chrome/app/theme:theme_resources", 16 "//chrome/app/theme:theme_resources",
19 "//extensions/browser/app_window",
20 "//extensions/common",
21 "//skia", 17 "//skia",
22 "//ui/gfx", 18 "//ui/gfx",
23 "//ui/strings", 19 "//ui/strings",
24 "//ui/views", 20 "//ui/views",
25 ] 21 ]
22
23 if (enable_extensions) {
24 deps += [
25 "//extensions/browser/app_window",
26 "//extensions/common",
27 ]
28 }
26 } 29 }
OLDNEW
« apps/BUILD.gn ('K') | « apps/BUILD.gn ('k') | chrome/browser/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698