Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Add assert(enable_extensions) to apps/BUILD.gn and fixup chrome/browser/media/router/BUILD.gn Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | apps/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This is the root build file for GN. GN will start processing by loading this 5 # This is the root build file for GN. GN will start processing by loading this
6 # file, and recursively load all dependencies until all dependencies are either 6 # file, and recursively load all dependencies until all dependencies are either
7 # resolved or known not to exist (which will cause the build to fail). So if 7 # resolved or known not to exist (which will cause the build to fail). So if
8 # you add a new build file, there must be some path of dependencies from this 8 # you add a new build file, there must be some path of dependencies from this
9 # file to your new one or GN won't know about it. 9 # file to your new one or GN won't know about it.
10 10
(...skipping 83 matching lines...) Expand 10 before | Expand all | Expand 10 after
94 94
95 if (!is_ios && !is_android && !is_chromecast && !is_fuchsia) { 95 if (!is_ios && !is_android && !is_chromecast && !is_fuchsia) {
96 deps += [ 96 deps += [
97 "//chrome", 97 "//chrome",
98 "//chrome/test:browser_tests", 98 "//chrome/test:browser_tests",
99 "//chrome/test:interactive_ui_tests", 99 "//chrome/test:interactive_ui_tests",
100 "//chrome/test:sync_integration_tests", 100 "//chrome/test:sync_integration_tests",
101 "//chrome/test/chromedriver:chromedriver_unittests", 101 "//chrome/test/chromedriver:chromedriver_unittests",
102 "//components/sync/tools:sync_client", 102 "//components/sync/tools:sync_client",
103 "//components/sync/tools:sync_listen_notifications", 103 "//components/sync/tools:sync_listen_notifications",
104 "//extensions:extensions_browsertests",
105 "//extensions:extensions_unittests",
106 "//gpu/gles2_conform_support:gles2_conform_test", 104 "//gpu/gles2_conform_support:gles2_conform_test",
107 "//gpu/khronos_glcts_support:khronos_glcts_test", 105 "//gpu/khronos_glcts_support:khronos_glcts_test",
108 "//jingle:jingle_unittests", 106 "//jingle:jingle_unittests",
109 "//net:hpack_example_generator", 107 "//net:hpack_example_generator",
110 "//ppapi:ppapi_unittests", 108 "//ppapi:ppapi_unittests",
111 "//ppapi/examples/2d", 109 "//ppapi/examples/2d",
112 "//ppapi/examples/audio", 110 "//ppapi/examples/audio",
113 "//ppapi/examples/audio_input", 111 "//ppapi/examples/audio_input",
114 "//ppapi/examples/compositor", 112 "//ppapi/examples/compositor",
115 "//ppapi/examples/crxfs", 113 "//ppapi/examples/crxfs",
(...skipping 26 matching lines...) Expand all
142 "//third_party/webrtc/tools:frame_analyzer", 140 "//third_party/webrtc/tools:frame_analyzer",
143 "//tools/battor_agent", 141 "//tools/battor_agent",
144 "//tools/battor_agent:battor_agent_unittests", 142 "//tools/battor_agent:battor_agent_unittests",
145 "//tools/gn", 143 "//tools/gn",
146 "//tools/gn:gn_unittests", 144 "//tools/gn:gn_unittests",
147 "//tools/perf/clear_system_cache", 145 "//tools/perf/clear_system_cache",
148 "//tools/traffic_annotation/auditor:traffic_annotation_auditor", 146 "//tools/traffic_annotation/auditor:traffic_annotation_auditor",
149 "//ui/accessibility:accessibility_unittests", 147 "//ui/accessibility:accessibility_unittests",
150 "//ui/accessibility/extensions", 148 "//ui/accessibility/extensions",
151 ] 149 ]
150
151 if (enable_extensions) {
152 deps += [
153 "//extensions:extensions_browsertests",
154 "//extensions:extensions_unittests",
155 ]
156 }
Dirk Pranke 2017/05/24 16:44:00 Can we move this block out of the condition (on li
hugoh_UTC2 2017/06/08 12:07:21 Done. See PS4.
152 } 157 }
153 158
154 if (!is_ios && !is_fuchsia) { 159 if (!is_ios && !is_fuchsia) {
155 deps += [ 160 deps += [
156 "//cc:cc_unittests", 161 "//cc:cc_unittests",
157 "//chrome/test:telemetry_perf_unittests", 162 "//chrome/test:telemetry_perf_unittests",
158 "//chrome/test:unit_tests", 163 "//chrome/test:unit_tests",
159 "//components:components_browsertests", 164 "//components:components_browsertests",
160 "//components/policy:policy_templates", 165 "//components/policy:policy_templates",
161 "//content/shell:content_shell", 166 "//content/shell:content_shell",
(...skipping 901 matching lines...) Expand 10 before | Expand all | Expand 10 after
1063 assert(target_name != "") # Mark as used. 1068 assert(target_name != "") # Mark as used.
1064 sources = invoker.actual_sources 1069 sources = invoker.actual_sources
1065 assert( 1070 assert(
1066 sources == invoker.actual_sources, 1071 sources == invoker.actual_sources,
1067 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283") 1072 "Do not use a platform name in your output directory (found \"$root_build_ dir\"). http://crbug.com/548283")
1068 } 1073 }
1069 1074
1070 assert_valid_out_dir("_unused") { 1075 assert_valid_out_dir("_unused") {
1071 actual_sources = [ "$root_build_dir/foo" ] 1076 actual_sources = [ "$root_build_dir/foo" ]
1072 } 1077 }
OLDNEW
« no previous file with comments | « no previous file | apps/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698