Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: chrome/browser/devtools/BUILD.gn

Issue 2904443004: Allow generation of a chromium outdirs when enable_extensions=false (Closed)
Patch Set: Assert enable_extensions: common/BUILD.gn and features/BUILD.gn are marked TODO(crbug.com/731689) Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 if (!is_android) { 5 if (!is_android) {
6 import("//build/config/features.gni") 6 import("//build/config/features.gni")
7 import("//chrome/common/features.gni") 7 import("//chrome/common/features.gni")
8 import("//tools/grit/grit_rule.gni") 8 import("//tools/grit/grit_rule.gni")
9 } 9 }
10 10
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 "//ui/events:dom_keycode_converter", 66 "//ui/events:dom_keycode_converter",
67 ] 67 ]
68 68
69 if (!is_android) { 69 if (!is_android) {
70 deps += [ 70 deps += [
71 "//chrome:extra_resources", 71 "//chrome:extra_resources",
72 "//chrome:resources", 72 "//chrome:resources",
73 "//chrome:strings", 73 "//chrome:strings",
74 "//chrome/app/theme:theme_resources", 74 "//chrome/app/theme:theme_resources",
75 "//chrome/common", 75 "//chrome/common",
76 "//chrome/common/extensions/api",
77 "//net:http_server", 76 "//net:http_server",
78 "//skia", 77 "//skia",
79 "//third_party/icu", 78 "//third_party/icu",
80 "//third_party/leveldatabase", 79 "//third_party/leveldatabase",
81 ] 80 ]
81
82 if (enable_extensions) {
83 deps += [ "//chrome/common/extensions/api" ]
Devlin 2017/06/09 19:11:51 I think conceptually this probably doesn't belong
hugoh_UTC2 2017/06/12 09:19:08 Done.
84 }
85
82 sources += [ 86 sources += [
83 "chrome_devtools_manager_delegate.cc", 87 "chrome_devtools_manager_delegate.cc",
84 "chrome_devtools_manager_delegate.h", 88 "chrome_devtools_manager_delegate.h",
85 "device/adb/adb_client_socket.cc", 89 "device/adb/adb_client_socket.cc",
86 "device/adb/adb_client_socket.h", 90 "device/adb/adb_client_socket.h",
87 "device/adb/adb_device_provider.cc", 91 "device/adb/adb_device_provider.cc",
88 "device/adb/adb_device_provider.h", 92 "device/adb/adb_device_provider.h",
89 "device/android_device_info_query.cc", 93 "device/android_device_info_query.cc",
90 "device/android_device_manager.cc", 94 "device/android_device_manager.cc",
91 "device/android_device_manager.h", 95 "device/android_device_manager.h",
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 "url_constants.h", 142 "url_constants.h",
139 ] 143 ]
140 if (enable_service_discovery) { 144 if (enable_service_discovery) {
141 sources += [ 145 sources += [
142 "device/cast_device_provider.cc", 146 "device/cast_device_provider.cc",
143 "device/cast_device_provider.h", 147 "device/cast_device_provider.h",
144 ] 148 ]
145 } 149 }
146 } 150 }
147 } 151 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698