Merge CommonElements and BackendHelpers!

Merge CommonElements and BackendHelpers!

BUG=
R=johnniwinther@google.com

Committed: https://github.com/dart-lang/sdk/commit/7697137485ae910d67871e72a1895ed3abd67173

[Emily Fortuna, 2017-04-11 00:56:14]

Patchset #1 (id:1) has been deleted

[Emily Fortuna, 2017-04-11 01:03:59]

efortuna@google.com changed reviewers:
+ johnniwinther@google.com

[Emily Fortuna, 2017-04-11 01:04:00]

HERE IT IS. The epic merge. 

A couple of things to note about how this change is:
1) I ended up removing CommmonElementsImpl and just used CommonElements. It
seemed like it would be a TOOOOON of code duplication to declare all of those
BackendHelpers interfaces and then define them in the Impl below. Since these
days dart2js is using private members for actual privacy, it seemed like the
Impl class is less necessary. Let me know if you disagree.
2) There are several places where my changes actually *added* a few "compiler."
calls (ie compiler.commonElements.foo). In none of these cases was I *adding* a
newly passed in compiler object, but if it was already being used in other
locations in the class I went ahead and used it. This was to try to avoid making
this change any larger than it is by also modifying constructors and such. That
can be done in a follow up CL.

[Johnni Winther, 2017-04-11 09:16:00]

lgtm

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common_elements.dart (right):

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common_elements.dart:435: class CommonElementsImpl
implements CommonElements {
It looks like something's gone wrong in the merge. It the previous patch set
[CommonElementImpl] was removed and all it's implementation moved to
[CommonElements].

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common_elements.dart:1162: abstract class
ElementEnvironment {
Again, bad merge. [ElementEnvironment] is also declared in line 346.

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_usage.dart (right):

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_usage.dart:154: print('mah source
position path ${element.sourcePosition.uri.path}');
Remove?

[Emily Fortuna, 2017-04-11 21:31:35]

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/co...
File pkg/compiler/lib/src/common_elements.dart (right):

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common_elements.dart:435: class CommonElementsImpl
implements CommonElements {
On 2017/04/11 09:16:00, Johnni Winther wrote:
> It looks like something's gone wrong in the merge. It the previous patch set
> [CommonElementImpl] was removed and all it's implementation moved to
> [CommonElements].

oh geez. sorry about that. I did the merge last minute before I ran to catch the
bus and clearly did it wrong (and set it to re-run the tests while I was out).
I've fixed it up now!

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/co...
pkg/compiler/lib/src/common_elements.dart:1162: abstract class
ElementEnvironment {
On 2017/04/11 09:16:00, Johnni Winther wrote:
> Again, bad merge. [ElementEnvironment] is also declared in line 346.

fixed up. thanks!

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_usage.dart (right):

https://codereview.chromium.org/2814453005/diff/80001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_usage.dart:154: print('mah source
position path ${element.sourcePosition.uri.path}');
On 2017/04/11 09:16:00, Johnni Winther wrote:
> Remove?

ooops, yes, thank you!

[Emily Fortuna, 2017-04-11 21:32:59]

Description was changed from

==========
Merge CommonElements and BackendHelpers!

BUG=
==========

to

==========
Merge CommonElements and BackendHelpers!

BUG=
R=johnniwinther@google.com

Committed:
https://github.com/dart-lang/sdk/commit/7697137485ae910d67871e72a1895ed3abd67173
==========

[Emily Fortuna, 2017-04-11 21:33:00]

Committed patchset #5 (id:100001) manually as
7697137485ae910d67871e72a1895ed3abd67173 (presubmit successful).