Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
index 91a189bb6691dc31f9bb415ca494d625c1fa49e7..f118dc2601208942af827d461a93c42587d89a3a 100644
--- a/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart
@@ -126,7 +126,8 @@ jsAst.Statement buildSetupProgram(Program program, Compiler compiler,
'needsNativeSupport': program.needsNativeSupport,
'enabledJsInterop': backend.jsInteropAnalysis.enabledJsInterop,
'jsInteropBoostrap': backend.jsInteropAnalysis.buildJsInteropBootstrap(),
- 'isInterceptorClass': namer.operatorIs(backend.helpers.jsInterceptorClass),
+ 'isInterceptorClass':
+ namer.operatorIs(compiler.commonElements.jsInterceptorClass),
'isObject': namer.operatorIs(compiler.commonElements.objectClass),
'specProperty': js.string(namer.nativeSpecProperty),
'trivialNsmHandlers': emitter.buildTrivialNsmHandlers(),
@@ -441,7 +442,7 @@ function $setupProgramName(programData, typesOffset) {
for (var i = 0; i < properties.length; i++) finishClass(properties[i]);
}
- // Generic handler for deferred class setup. The handler updates the
+ // Generic handler for deferred class setup. The handler updates the
// prototype that it is installed on (it traverses the prototype chain
// of [this] to find itself) and then removes itself. It recurses by
// calling deferred handling again, which terminates on Object due to
@@ -734,7 +735,7 @@ function $setupProgramName(programData, typesOffset) {
if (isSetter) {
reflectionName += "=";
} else if (!isGetter) {
- reflectionName += ":" +
+ reflectionName += ":" +
(requiredParameterCount + optionalParameterCount);
}
mangledNames[name] = reflectionName;

Powered by Google App Engine
This is Rietveld 408576698