Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: pkg/compiler/lib/src/js_backend/impact_transformer.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/impact_transformer.dart
diff --git a/pkg/compiler/lib/src/js_backend/impact_transformer.dart b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
index 134de40c1c6d6b9c810e3fd91fdd6911d8d7ff1a..02393a1fee571d2d16ee5b632057953c69848b96 100644
--- a/pkg/compiler/lib/src/js_backend/impact_transformer.dart
+++ b/pkg/compiler/lib/src/js_backend/impact_transformer.dart
@@ -24,7 +24,6 @@ import '../universe/use.dart'
import '../universe/world_impact.dart' show TransformedWorldImpact, WorldImpact;
import '../util/util.dart';
import 'backend.dart';
-import 'backend_helpers.dart';
import 'backend_impact.dart';
import 'backend_usage.dart';
import 'checked_mode_helpers.dart';
@@ -335,7 +334,7 @@ class JavaScriptImpactTransformer extends ImpactTransformer {
class CodegenImpactTransformer {
final CompilerOptions _options;
final ElementEnvironment _elementEnvironment;
- final BackendHelpers _helpers;
+ final CommonElements _commonElements;
final BackendImpacts _impacts;
final CheckedModeHelpers _checkedModeHelpers;
final NativeData _nativeData;
@@ -350,7 +349,7 @@ class CodegenImpactTransformer {
CodegenImpactTransformer(
this._options,
this._elementEnvironment,
- this._helpers,
+ this._commonElements,
this._impacts,
this._checkedModeHelpers,
this._nativeData,
@@ -378,14 +377,14 @@ class CodegenImpactTransformer {
CheckedModeHelper helper =
_checkedModeHelpers.getCheckedModeHelper(type, typeCast: false);
if (helper != null) {
- StaticUse staticUse = helper.getStaticUse(_helpers);
+ StaticUse staticUse = helper.getStaticUse(_commonElements);
transformed.registerStaticUse(staticUse);
}
// We also need the native variant of the check (for DOM types).
helper =
_checkedModeHelpers.getNativeCheckedModeHelper(type, typeCast: false);
if (helper != null) {
- StaticUse staticUse = helper.getStaticUse(_helpers);
+ StaticUse staticUse = helper.getStaticUse(_commonElements);
transformed.registerStaticUse(staticUse);
}
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/frequency_namer.dart ('k') | pkg/compiler/lib/src/js_backend/interceptor_data.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698