Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: pkg/compiler/lib/src/js_backend/no_such_method_registry.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
diff --git a/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart b/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
index b799a9ac0e882dde5afd377ea1f61d25d6d4832c..a401e0585eb1de672ccca32915527e929a9f714e 100644
--- a/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
+++ b/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
@@ -3,12 +3,12 @@
// BSD-style license that can be found in the LICENSE file.
import '../common.dart';
+import '../common_elements.dart' show CommonElements;
import '../common/names.dart' show Identifiers, Names, Selectors;
import '../elements/elements.dart';
import '../elements/entities.dart';
import '../types/types.dart';
import '../tree/tree.dart';
-import 'backend_helpers.dart';
/**
* Categorizes `noSuchMethod` implementations.
@@ -69,10 +69,10 @@ class NoSuchMethodRegistry {
/// The implementations that have not yet been categorized.
final Set<FunctionEntity> _uncategorizedImpls = new Set<FunctionEntity>();
- final BackendHelpers _helpers;
+ final CommonElements _commonElements;
final NoSuchMethodResolver _resolver;
- NoSuchMethodRegistry(this._helpers, this._resolver);
+ NoSuchMethodRegistry(this._commonElements, this._resolver);
bool get hasThrowingNoSuchMethod => throwingImpls.isNotEmpty;
bool get hasComplexNoSuchMethod => otherImpls.isNotEmpty;
@@ -146,7 +146,7 @@ class NoSuchMethodRegistry {
notApplicableImpls.add(element);
return NsmCategory.NOT_APPLICABLE;
}
- if (_helpers.isDefaultNoSuchMethodImplementation(element)) {
+ if (_commonElements.isDefaultNoSuchMethodImplementation(element)) {
defaultImpls.add(element);
return NsmCategory.DEFAULT;
} else if (_resolver.hasForwardingSyntax(element)) {
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_backend/resolution_listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698