Merge CommonElements and BackendHelpers!

pkg/compiler/lib/src/js_backend/interceptor_data.dart

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library js_backend.interceptor_data;
 
 import '../common/names.dart' show Identifiers;
 import '../common_elements.dart' show CommonElements, ElementEnvironment;
 import '../elements/elements.dart' show MemberElement;
 import '../elements/entities.dart';
 import '../elements/types.dart';
 import '../js/js.dart' as jsAst;
 import '../types/types.dart' show TypeMask;
 import '../universe/selector.dart';
 import '../world.dart' show ClosedWorld;
-import 'backend_helpers.dart';
 import 'namer.dart';
 import 'native_data.dart';
 
 abstract class InterceptorData {
   /// Returns `true` if [cls] is an intercepted class.
   bool isInterceptedClass(ClassEntity element);
 
   bool isInterceptedMethod(MemberEntity element);
   bool fieldHasInterceptedGetter(FieldEntity element);
   bool fieldHasInterceptedSetter(FieldEntity element);
@@ skipping 15 matching lines @@
 }
 
 abstract class InterceptorDataBuilder {
   void addInterceptors(ClassEntity cls);
   void addInterceptorsForNativeClassMembers(ClassEntity cls);
   InterceptorData onResolutionComplete(ClosedWorld closedWorld);
 }
 
 class InterceptorDataImpl implements InterceptorData {
   final NativeBasicData _nativeData;
-  final BackendHelpers _helpers;
+  final CommonElements _commonElements;
   final ClosedWorld _closedWorld;
 
   /// The members of instantiated interceptor classes: maps a member name to the
   /// list of members that have that name. This map is used by the codegen to
   /// know whether a send must be intercepted or not.
   final Map<String, Set<MemberEntity>> _interceptedElements;
 
   /// Set of classes whose methods are intercepted.
   final Set<ClassEntity> _interceptedClasses;
 
@@ skipping 14 matching lines @@
   final Map<String, Set<MemberEntity>> _interceptedMixinElements =
       new Map<String, Set<MemberEntity>>();
 
   final Map<String, Set<ClassEntity>> _interceptedClassesCache =
       new Map<String, Set<ClassEntity>>();
 
   final Set<ClassEntity> _noClasses = new Set<ClassEntity>();
 
   InterceptorDataImpl(
       this._nativeData,
-      this._helpers,
+      this._commonElements,
       this._closedWorld,
       this._interceptedElements,
       this._interceptedClasses,
       this._classesMixedIntoInterceptedClasses);
 
   bool isInterceptedMethod(MemberElement element) {
     if (!element.isInstanceMember) return false;
     if (element.isGenerativeConstructorBody) {
       return _nativeData.isNativeOrExtendsNative(element.enclosingClass);
     }
@@ skipping 34 matching lines @@
     if (elements.isEmpty) return false;
     return elements.any((element) {
       return selector.applies(element) &&
           (mask == null || mask.canHit(element, selector, _closedWorld));
     });
   }
 
   /// True if the given class is an internal class used for type inference
   /// and never exists at runtime.
   bool _isCompileTimeOnlyClass(ClassEntity class_) {
-    return class_ == _helpers.jsPositiveIntClass ||
-        class_ == _helpers.jsUInt32Class ||
-        class_ == _helpers.jsUInt31Class ||
-        class_ == _helpers.jsFixedArrayClass ||
-        class_ == _helpers.jsUnmodifiableArrayClass ||
-        class_ == _helpers.jsMutableArrayClass ||
-        class_ == _helpers.jsExtendableArrayClass;
+    return class_ == _commonElements.jsPositiveIntClass ||
+        class_ == _commonElements.jsUInt32Class ||
+        class_ == _commonElements.jsUInt31Class ||
+        class_ == _commonElements.jsFixedArrayClass ||
+        class_ == _commonElements.jsUnmodifiableArrayClass ||
+        class_ == _commonElements.jsMutableArrayClass ||
+        class_ == _commonElements.jsExtendableArrayClass;
   }
 
   /// Returns a set of interceptor classes that contain a member named [name]
   ///
   /// Returns an empty set if there is no class. Do not modify the returned set.
   Set<ClassEntity> getInterceptedClassesOn(String name) {
     Set<MemberEntity> intercepted = _interceptedElements[name];
     if (intercepted == null) return _noClasses;
     return _interceptedClassesCache.putIfAbsent(name, () {
       // Populate the cache by running through all the elements and
@@ skipping 50 matching lines @@
     if (!type.treatAsRaw) return false;
     InterfaceType interfaceType = type;
     ClassEntity classElement = interfaceType.element;
     if (isInterceptedClass(classElement)) return false;
     return _closedWorld.hasOnlySubclasses(classElement);
   }
 }
 
 class InterceptorDataBuilderImpl implements InterceptorDataBuilder {
   final NativeBasicData _nativeData;
-  final BackendHelpers _helpers;
   final ElementEnvironment _elementEnvironment;
   final CommonElements _commonElements;
 
   /// The members of instantiated interceptor classes: maps a member name to the
   /// list of members that have that name. This map is used by the codegen to
   /// know whether a send must be intercepted or not.
   final Map<String, Set<MemberEntity>> _interceptedElements =
       <String, Set<MemberEntity>>{};
 
   /// Set of classes whose methods are intercepted.
   final Set<ClassEntity> _interceptedClasses = new Set<ClassEntity>();
 
   /// Set of classes used as mixins on intercepted (native and primitive)
   /// classes. Methods on these classes might also be mixed in to regular Dart
   /// (unintercepted) classes.
   final Set<ClassEntity> _classesMixedIntoInterceptedClasses =
       new Set<ClassEntity>();
 
-  InterceptorDataBuilderImpl(this._nativeData, this._helpers,
-      this._elementEnvironment, this._commonElements);
+  InterceptorDataBuilderImpl(
+      this._nativeData, this._elementEnvironment, this._commonElements);
 
   InterceptorData onResolutionComplete(ClosedWorld closedWorld) {
     return new InterceptorDataImpl(
         _nativeData,
-        _helpers,
+        _commonElements,
         closedWorld,
         _interceptedElements,
         _interceptedClasses,
         _classesMixedIntoInterceptedClasses);
   }
 
   void addInterceptorsForNativeClassMembers(ClassEntity cls) {
     _elementEnvironment.forEachClassMember(cls,
         (ClassEntity cls, MemberEntity member) {
       if (member.name == Identifiers.call) return;
@@ skipping 14 matching lines @@
     if (_interceptedClasses.add(cls)) {
       _elementEnvironment.forEachClassMember(cls,
           (ClassEntity cls, MemberEntity member) {
         // All methods on [Object] are shadowed by [Interceptor].
         if (cls == _commonElements.objectClass) return;
         Set<MemberEntity> set = _interceptedElements.putIfAbsent(
             member.name, () => new Set<MemberEntity>());
         set.add(member);
       });
     }
-    _interceptedClasses.add(_helpers.jsInterceptorClass);
+    _interceptedClasses.add(_commonElements.jsInterceptorClass);
   }
 }
 
 class OneShotInterceptorData {
   final InterceptorData _interceptorData;
-  final BackendHelpers _helpers;
+  final CommonElements _commonElements;
 
-  OneShotInterceptorData(this._interceptorData, this._helpers);
+  OneShotInterceptorData(this._interceptorData, this._commonElements);
 
   /// A collection of selectors that must have a one shot interceptor generated.
   final Map<jsAst.Name, Selector> _oneShotInterceptors =
       <jsAst.Name, Selector>{};
 
   Selector getOneShotInterceptorSelector(jsAst.Name name) =>
       _oneShotInterceptors[name];
 
   Iterable<jsAst.Name> get oneShotInterceptorNames =>
       _oneShotInterceptors.keys.toList()..sort();
@@ skipping 20 matching lines @@
     if (!_oneShotInterceptors.containsKey(name)) {
       registerSpecializedGetInterceptor(classes, namer);
       _oneShotInterceptors[name] = selector;
     }
     return name;
   }
 
   void registerSpecializedGetInterceptor(
       Set<ClassEntity> classes, Namer namer) {
     jsAst.Name name = namer.nameForGetInterceptor(classes);
-    if (classes.contains(_helpers.jsInterceptorClass)) {
+    if (classes.contains(_commonElements.jsInterceptorClass)) {
       // We can't use a specialized [getInterceptorMethod], so we make
       // sure we emit the one with all checks.
       _specializedGetInterceptors[name] = _interceptorData.interceptedClasses;
     } else {
       _specializedGetInterceptors[name] = classes;
     }
   }
 }