Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart
diff --git a/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart b/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart
index 59192df37af449c5bc3cd0f4de1f082a544b0170..8c8d4588d565439ca61aabf48f2c36e3b642c9ac 100644
--- a/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart
+++ b/pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart
@@ -26,7 +26,6 @@ import '../elements/resolution_types.dart' show ResolutionInterfaceType;
import '../universe/use.dart' show ConstantUse, StaticUse;
import '../universe/world_impact.dart'
show WorldImpact, StagedWorldImpactBuilder;
-import 'backend_helpers.dart';
/// Lookup map handling for resolution.
///
@@ -128,7 +127,6 @@ class LookupMapAnalysis {
ConstantEnvironment constants,
ElementEnvironment elementEnvironment,
CommonElements commonElements,
- BackendHelpers helpers,
BackendClasses backendClasses,
LookupMapResolutionAnalysis analysis) {
/// Checks if the version of lookup_map is valid, and if so, enable this
@@ -169,7 +167,7 @@ class LookupMapAnalysis {
elementEnvironment.lookupClassMember(typeLookupMapClass, '_value');
// TODO(sigmund): Maybe inline nested maps to make the output code smaller?
- return new _LookupMapAnalysis(constantSystem, commonElements, helpers,
+ return new _LookupMapAnalysis(constantSystem, commonElements,
backendClasses, entriesField, keyField, valueField, typeLookupMapClass);
}
@@ -207,8 +205,6 @@ class _LookupMapAnalysis implements LookupMapAnalysis {
final CommonElements _commonElements;
- final BackendHelpers _helpers;
-
final BackendClasses _backendClasses;
/// The resolved [ClassElement] associated with `LookupMap`.
@@ -254,7 +250,6 @@ class _LookupMapAnalysis implements LookupMapAnalysis {
_LookupMapAnalysis(
this._constantSystem,
this._commonElements,
- this._helpers,
this._backendClasses,
this._entriesField,
this._keyField,
@@ -351,7 +346,7 @@ class _LookupMapAnalysis implements LookupMapAnalysis {
// TODO(sigmund): can we get rid of this?
_impactBuilder.registerStaticUse(new StaticUse.staticInvoke(
// TODO(johnniwinther): Find the right [CallStructure].
- _helpers.createRuntimeType,
+ _commonElements.createRuntimeType,
null));
_addGenerics(arg);
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/js_interop_analysis.dart ('k') | pkg/compiler/lib/src/js_backend/minify_namer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698