Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Unified Diff: pkg/compiler/lib/src/kernel/world_builder.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/kernel/element_adapter.dart ('k') | pkg/compiler/lib/src/native/behavior.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/kernel/world_builder.dart
diff --git a/pkg/compiler/lib/src/kernel/world_builder.dart b/pkg/compiler/lib/src/kernel/world_builder.dart
index b9b46fd0657903f9fced52d0aa0151b923c307e5..5b8527a68fdcfad09c767f2a336097cbad23fcf7 100644
--- a/pkg/compiler/lib/src/kernel/world_builder.dart
+++ b/pkg/compiler/lib/src/kernel/world_builder.dart
@@ -19,7 +19,6 @@ import '../common_elements.dart';
import '../elements/elements.dart';
import '../elements/entities.dart';
import '../elements/types.dart';
-import '../js_backend/backend_helpers.dart';
import '../js_backend/constant_system_javascript.dart';
import '../js_backend/no_such_method_registry.dart';
import '../native/native.dart' as native;
@@ -78,10 +77,10 @@ class KernelWorldBuilder extends KernelElementAdapterMixin {
KernelWorldBuilder(this.reporter, ir.Program program)
: _env = new KEnv(program) {
_elementEnvironment = new KernelElementEnvironment(this);
- _commonElements = new CommonElementsImpl(_elementEnvironment);
+ _commonElements = new CommonElements(_elementEnvironment);
ConstantEnvironment constants = new KernelConstantEnvironment(this);
_nativeBehaviorBuilder =
- new KernelBehaviorBuilder(_commonElements, helpers, constants);
+ new KernelBehaviorBuilder(_commonElements, constants);
_typeConverter = new DartTypeConverter(this);
}
@@ -863,10 +862,9 @@ class DartTypeConverter extends ir.DartTypeVisitor<DartType> {
/// [native.BehaviorBuilder] for kernel based elements.
class KernelBehaviorBuilder extends native.BehaviorBuilder {
final CommonElements commonElements;
- final BackendHelpers helpers;
final ConstantEnvironment constants;
- KernelBehaviorBuilder(this.commonElements, this.helpers, this.constants);
+ KernelBehaviorBuilder(this.commonElements, this.constants);
@override
bool get trustJSInteropTypeAnnotations {
« no previous file with comments | « pkg/compiler/lib/src/kernel/element_adapter.dart ('k') | pkg/compiler/lib/src/native/behavior.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698