pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart - Issue 2814453005: Merge CommonElements and BackendHelpers!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)

Patch Set: comments and re-merge, take two Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/kernel/element_adapter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

index 7dc3001e4f4389f77fd3eeca1f226347818b4d9a..2f975d10e12769c25c54cb48339ed8e4e576dd4f 100644

--- a/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart

@@ -362,7 +362,7 @@ const String directAccessTestExpression = r'''

var object = new cls();

if (!(object.__proto__ && object.__proto__.p === cls.prototype.p))

return false;

try {

// Are we running on a platform where the performance is good?

// (i.e. Chrome or d8).

@@ -468,7 +468,7 @@ class FragmentEmitter {

'directAccessTestExpression': js.js(directAccessTestExpression),

'typeNameProperty': js.string(ModelEmitter.typeNameProperty),

'cyclicThrow': backend.emitter

- .staticFunctionAccess(backend.helpers.cyclicThrowHelper),

+ .staticFunctionAccess(compiler.commonElements.cyclicThrowHelper),

'operatorIsPrefix': js.string(namer.operatorIsPrefix),

'tearOffCode': new js.Block(buildTearOffCode(backend)),

'embeddedTypes': generateEmbeddedGlobalAccess(TYPES),

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart ('k') | pkg/compiler/lib/src/kernel/element_adapter.dart » ('j') | no next file with comments »