Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Side by Side Diff: pkg/compiler/lib/src/inferrer/map_tracer.dart

Issue 2814453005: Merge CommonElements and BackendHelpers! (Closed)
Patch Set: comments and re-merge, take two Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library compiler.src.inferrer.map_tracer; 5 library compiler.src.inferrer.map_tracer;
6 6
7 import '../elements/elements.dart'; 7 import '../elements/elements.dart';
8 import '../js_backend/backend_helpers.dart'; 8 import '../js_backend/backend.dart' show JavaScriptBackend;
9 import '../universe/selector.dart' show Selector; 9 import '../universe/selector.dart' show Selector;
10 import 'node_tracer.dart'; 10 import 'node_tracer.dart';
11 import 'type_graph_nodes.dart'; 11 import 'type_graph_nodes.dart';
12 12
13 Set<String> okMapSelectorsSet = new Set.from(const <String>[ 13 Set<String> okMapSelectorsSet = new Set.from(const <String>[
14 // From Object. 14 // From Object.
15 "==", 15 "==",
16 "hashCode", 16 "hashCode",
17 "toString", 17 "toString",
18 "noSuchMethod", 18 "noSuchMethod",
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
61 } 61 }
62 62
63 visitClosureCallSiteTypeInformation(ClosureCallSiteTypeInformation info) { 63 visitClosureCallSiteTypeInformation(ClosureCallSiteTypeInformation info) {
64 bailout('Passed to a closure'); 64 bailout('Passed to a closure');
65 } 65 }
66 66
67 visitStaticCallSiteTypeInformation(StaticCallSiteTypeInformation info) { 67 visitStaticCallSiteTypeInformation(StaticCallSiteTypeInformation info) {
68 super.visitStaticCallSiteTypeInformation(info); 68 super.visitStaticCallSiteTypeInformation(info);
69 Element called = info.calledElement; 69 Element called = info.calledElement;
70 if (compiler.backend.isForeign(called) && 70 if (compiler.backend.isForeign(called) &&
71 called.name == BackendHelpers.JS) { 71 called.name == JavaScriptBackend.JS) {
72 bailout('Used in JS ${info.call}'); 72 bailout('Used in JS ${info.call}');
73 } 73 }
74 } 74 }
75 75
76 visitDynamicCallSiteTypeInformation(DynamicCallSiteTypeInformation info) { 76 visitDynamicCallSiteTypeInformation(DynamicCallSiteTypeInformation info) {
77 super.visitDynamicCallSiteTypeInformation(info); 77 super.visitDynamicCallSiteTypeInformation(info);
78 Selector selector = info.selector; 78 Selector selector = info.selector;
79 String selectorName = selector.name; 79 String selectorName = selector.name;
80 if (currentUser == info.receiver) { 80 if (currentUser == info.receiver) {
81 if (!okMapSelectorsSet.contains(selectorName)) { 81 if (!okMapSelectorsSet.contains(selectorName)) {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
121 return; 121 return;
122 } 122 }
123 } 123 }
124 } else if (selector.isCall && 124 } else if (selector.isCall &&
125 !info.targets.every((element) => element.isFunction)) { 125 !info.targets.every((element) => element.isFunction)) {
126 bailout('Passed to a closure'); 126 bailout('Passed to a closure');
127 return; 127 return;
128 } 128 }
129 } 129 }
130 } 130 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/inferrer/list_tracer.dart ('k') | pkg/compiler/lib/src/js_backend/annotations.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698