Merge CommonElements and BackendHelpers!

tests/compiler/dart2js/kernel/closed_world2_test.dart

-// Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Partial test that the closed world computed from [WorldImpact]s derived from
 // kernel is equivalent to the original computed from resolution.
 library dart2js.kernel.closed_world2_test;
 
 import 'package:async_helper/async_helper.dart';
 import 'package:compiler/src/closure.dart';
 import 'package:compiler/src/commandline_options.dart';
 import 'package:compiler/src/common.dart';
 import 'package:compiler/src/common_elements.dart';
 import 'package:compiler/src/common/backend_api.dart';
 import 'package:compiler/src/common/resolution.dart';
 import 'package:compiler/src/common/work.dart';
 import 'package:compiler/src/compiler.dart';
 import 'package:compiler/src/deferred_load.dart';
 import 'package:compiler/src/elements/resolution_types.dart';
 import 'package:compiler/src/elements/elements.dart';
 import 'package:compiler/src/elements/entities.dart';
 import 'package:compiler/src/elements/types.dart';
 import 'package:compiler/src/enqueue.dart';
 import 'package:compiler/src/js_backend/backend.dart';
-import 'package:compiler/src/js_backend/backend_helpers.dart';
 import 'package:compiler/src/js_backend/backend_impact.dart';
 import 'package:compiler/src/js_backend/backend_usage.dart';
 import 'package:compiler/src/js_backend/custom_elements_analysis.dart';
 import 'package:compiler/src/js_backend/native_data.dart';
 import 'package:compiler/src/js_backend/impact_transformer.dart';
 import 'package:compiler/src/js_backend/interceptor_data.dart';
 import 'package:compiler/src/js_backend/lookup_map_analysis.dart';
 import 'package:compiler/src/js_backend/mirrors_analysis.dart';
 import 'package:compiler/src/js_backend/mirrors_data.dart';
 import 'package:compiler/src/js_backend/no_such_method_registry.dart';
@@ skipping 59 matching lines @@
 
     computeClosedWorld(
         compiler.reporter, enqueuer, worldBuilder.elementEnvironment);
   });
 }
 
 List createKernelResolutionEnqueuerListener(CompilerOptions options,
     DeferredLoadTask deferredLoadTask, KernelWorldBuilder worldBuilder) {
   ElementEnvironment elementEnvironment = worldBuilder.elementEnvironment;
   CommonElements commonElements = worldBuilder.commonElements;
-  BackendHelpers helpers =
-      new BackendHelpers(elementEnvironment, commonElements);
-  BackendImpacts impacts = new BackendImpacts(options, commonElements, helpers);
+  BackendImpacts impacts = new BackendImpacts(options, commonElements);
 
   // TODO(johnniwinther): Create Kernel based implementations for these:
   NativeBasicData nativeBasicData = new NativeBasicDataImpl();
   RuntimeTypesNeedBuilder rtiNeedBuilder = new RuntimeTypesNeedBuilderImpl();
   MirrorsDataBuilder mirrorsDataBuilder = new MirrorsDataBuilderImpl();
   CustomElementsResolutionAnalysis customElementsResolutionAnalysis =
       new CustomElementsResolutionAnalysisImpl();
   LookupMapResolutionAnalysis lookupMapResolutionAnalysis =
       new LookupMapResolutionAnalysisImpl();
   MirrorsResolutionAnalysis mirrorsResolutionAnalysis =
       new MirrorsResolutionAnalysisImpl();
 
   BackendClasses backendClasses = new JavaScriptBackendClasses(
-      elementEnvironment, helpers, nativeBasicData);
+      elementEnvironment, commonElements, nativeBasicData);
   InterceptorDataBuilder interceptorDataBuilder =
       new InterceptorDataBuilderImpl(
-          nativeBasicData, helpers, elementEnvironment, commonElements);
+          nativeBasicData, elementEnvironment, commonElements);
   BackendUsageBuilder backendUsageBuilder =
-      new BackendUsageBuilderImpl(commonElements, helpers);
+      new BackendUsageBuilderImpl(commonElements);
   NoSuchMethodRegistry noSuchMethodRegistry = new NoSuchMethodRegistry(
-      helpers, new KernelNoSuchMethodResolver(worldBuilder));
+      commonElements, new KernelNoSuchMethodResolver(worldBuilder));
   NativeResolutionEnqueuer nativeResolutionEnqueuer =
       new NativeResolutionEnqueuer(
           options,
           elementEnvironment,
           commonElements,
-          helpers,
           backendClasses,
           backendUsageBuilder,
           new KernelNativeClassResolver(worldBuilder));
 
   ResolutionEnqueuerListener listener = new ResolutionEnqueuerListener(
       options,
       elementEnvironment,
       commonElements,
-      helpers,
       impacts,
       backendClasses,
       nativeBasicData,
       interceptorDataBuilder,
       backendUsageBuilder,
       rtiNeedBuilder,
       mirrorsDataBuilder,
       noSuchMethodRegistry,
       customElementsResolutionAnalysis,
       lookupMapResolutionAnalysis,
@@ skipping 55 matching lines @@
 class RuntimeTypesNeedBuilderImpl implements RuntimeTypesNeedBuilder {
   @override
   void registerClassUsingTypeVariableExpression(ClassEntity cls) {}
 
   @override
   RuntimeTypesNeed computeRuntimeTypesNeed(
       ResolutionWorldBuilder resolutionWorldBuilder,
       ClosedWorld closedWorld,
       DartTypes types,
       CommonElements commonElements,
-      BackendHelpers helpers,
       BackendUsage backendUsage,
       {bool enableTypeAssertions}) {
     throw new UnimplementedError(
         'RuntimeTypesNeedBuilderImpl.computeRuntimeTypesNeed');
   }
 
   @override
   void registerRtiDependency(ClassEntity element, ClassEntity dependency) {}
 }
 
@@ skipping 89 matching lines @@
   final MemberEntity element;
 
   KernelWorkItem(this._worldBuilder, this._impactTransformer, this.element);
 
   @override
   WorldImpact run() {
     ResolutionImpact impact = _worldBuilder.computeWorldImpact(element);
     return _impactTransformer.transformResolutionImpact(impact);
   }
 }