Merge CommonElements and BackendHelpers!

pkg/compiler/lib/src/js_backend/no_such_method_registry.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import '../common.dart';
+import '../common_elements.dart' show CommonElements;
 import '../common/names.dart' show Identifiers, Names, Selectors;
 import '../elements/elements.dart';
 import '../elements/entities.dart';
 import '../types/types.dart';
 import '../tree/tree.dart';
-import 'backend_helpers.dart';
 
 /**
  * Categorizes `noSuchMethod` implementations.
  *
  * If user code includes `noSuchMethod` implementations, type inference is
  * hindered because (for instance) any selector where the type of the
  * receiver is not known all implementations of `noSuchMethod` must be taken
  * into account when inferring the return type.
  *
  * The situation can be ameliorated with some heuristics for disregarding some
@@ skipping 40 matching lines @@
 
   /// The implementations that fall into category D1
   final Set<FunctionEntity> complexNoReturnImpls = new Set<FunctionEntity>();
 
   /// The implementations that fall into category D2
   final Set<FunctionEntity> complexReturningImpls = new Set<FunctionEntity>();
 
   /// The implementations that have not yet been categorized.
   final Set<FunctionEntity> _uncategorizedImpls = new Set<FunctionEntity>();
 
-  final BackendHelpers _helpers;
+  final CommonElements _commonElements;
   final NoSuchMethodResolver _resolver;
 
-  NoSuchMethodRegistry(this._helpers, this._resolver);
+  NoSuchMethodRegistry(this._commonElements, this._resolver);
 
   bool get hasThrowingNoSuchMethod => throwingImpls.isNotEmpty;
   bool get hasComplexNoSuchMethod => otherImpls.isNotEmpty;
 
   void registerNoSuchMethod(FunctionEntity noSuchMethodElement) {
     _uncategorizedImpls.add(noSuchMethodElement);
   }
 
   void onQueueEmpty() {
     _uncategorizedImpls.forEach(_categorizeImpl);
@@ skipping 53 matching lines @@
     if (otherImpls.contains(element)) {
       return NsmCategory.OTHER;
     }
     if (notApplicableImpls.contains(element)) {
       return NsmCategory.NOT_APPLICABLE;
     }
     if (!Selectors.noSuchMethod_.signatureApplies(element)) {
       notApplicableImpls.add(element);
       return NsmCategory.NOT_APPLICABLE;
     }
-    if (_helpers.isDefaultNoSuchMethodImplementation(element)) {
+    if (_commonElements.isDefaultNoSuchMethodImplementation(element)) {
       defaultImpls.add(element);
       return NsmCategory.DEFAULT;
     } else if (_resolver.hasForwardingSyntax(element)) {
       // If the implementation is 'noSuchMethod(x) => super.noSuchMethod(x);'
       // then it is in the same category as the super call.
       FunctionEntity superCall = _resolver.getSuperNoSuchMethod(element);
       NsmCategory category = _categorizeImpl(superCall);
       switch (category) {
         case NsmCategory.DEFAULT:
           defaultImpls.add(element);
@@ skipping 121 matching lines @@
         return stmt.expression is Throw;
       }
     }
     return false;
   }
 
   MethodElement getSuperNoSuchMethod(MethodElement method) {
     return method.enclosingClass.lookupSuperByName(Names.noSuchMethod_);
   }
 }