Migrate WTF::Vector::remove() to ::erase()

Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2776203002
Cr-Commit-Position: refs/heads/master@{#460215}
Committed: https://chromium.googlesource.com/chromium/src/+/3e2545eea28039a76b9c056c84fddac3cbc9d7d8

[pilgrim_google, 2017-03-27 16:50:39]

Description was changed from

==========
Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-03-27 16:50:40]

Description was changed from

==========
Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-03-27 16:52:08]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2017-03-27 16:52:29]

pilgrim@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2017-03-27 16:52:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 16:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 16:57:57]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[pilgrim_google, 2017-03-27 17:22:18]

On 2017/03/27 at 16:52:30, pilgrim_google wrote:
> 

Wow this is failing everywhere, I think because of the wtf -> platform/wtf
migration. Investigating. Ignore for now.

[haraken, 2017-03-28 01:53:26]

LGTM

[Yuta Kitamura, 2017-03-28 09:16:40]

The trybots results are bloody, because my last change moving
VectorTest.cpp got reverted. Sorry about that.

Feel free to do either:

(1) Sync to ToT and apply the change to wtf/VectorTest.cpp
    instead of platform/wtf/VectorTest.cpp, or
(2) Wait and try to land this again after I reland my
    reverted change.

FYI, it will take some more time (1+ day) for me to reland
my reverted CL, since the core issue of my CL is very tricky.

[pilgrim_google, 2017-03-28 18:51:21]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-03-28 18:51:22]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2776203002/#ps20001
(title: "rebase, repatch VectorTest")

[pilgrim_google, 2017-03-28 18:51:52]

On 2017/03/28 at 09:16:40, yutak wrote:
> The trybots results are bloody, because my last change moving
> VectorTest.cpp got reverted. Sorry about that.
> 
> Feel free to do either:
> 
> (1) Sync to ToT and apply the change to wtf/VectorTest.cpp
>     instead of platform/wtf/VectorTest.cpp, or
> (2) Wait and try to land this again after I reland my
>     reverted change.
> 
> FYI, it will take some more time (1+ day) for me to reland
> my reverted CL, since the core issue of my CL is very tricky.

I chose (1). Thanks for clarifying!

[commit-bot: I haz the power, 2017-03-28 18:52:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 19:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:07:43]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pilgrim_google, 2017-03-28 19:24:19]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2017-03-28 19:24:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 20:51:39]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490729059143640,
"parent_rev": "ff5026c59eda509f6f73caee29a4b36042d2e4f9", "commit_rev":
"3e2545eea28039a76b9c056c84fddac3cbc9d7d8"}

[commit-bot: I haz the power, 2017-03-28 20:52:31]

Description was changed from

==========
Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Migrate WTF::Vector::remove() to ::erase()

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2776203002
Cr-Commit-Position: refs/heads/master@{#460215}
Committed:
https://chromium.googlesource.com/chromium/src/+/3e2545eea28039a76b9c056c84fd...
==========

[commit-bot: I haz the power, 2017-03-28 20:52:34]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3e2545eea28039a76b9c056c84fd...