Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)
Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
index a2e8494c05fd5de75602dd878e9e4cc84079c6c9..4b5d033c6d457505ddf0e83319f646452cba8280 100644
--- a/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp
@@ -83,7 +83,7 @@ void ScriptPromisePropertyBase::resolveOrReject(State targetState) {
// wrapper has died.
// Since v8 GC can run during the iteration and clear the reference,
// we can't move this check out of the loop.
- m_wrappers.remove(i);
+ m_wrappers.erase(i);
continue;
}
v8::Local<v8::Object> wrapper = persistent->newLocal(m_isolate);
@@ -136,7 +136,7 @@ v8::Local<v8::Object> ScriptPromisePropertyBase::ensureHolderWrapper(
// wrapper has died.
// Since v8 GC can run during the iteration and clear the reference,
// we can't move this check out of the loop.
- m_wrappers.remove(i);
+ m_wrappers.erase(i);
continue;
}

Powered by Google App Engine
This is Rietveld 408576698