third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

diff --git a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

index 64a1f72c30316bbc9f92a12042eb15e3585ba45d..50c995635c6e7b2c6a432fce4aae10f6bc779478 100644

--- a/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

+++ b/third_party/WebKit/Source/core/animation/KeyframeEffectModel.cpp

@@ -298,7 +298,7 @@ void KeyframeEffectModelBase::PropertySpecificKeyframeGroup::

m_keyframes[i - 1]->offset() == offset;

bool hasSameOffsetAsNextNeighbor = m_keyframes[i + 1]->offset() == offset;

if (hasSameOffsetAsPreviousNeighbor && hasSameOffsetAsNextNeighbor)

- m_keyframes.remove(i);

+ m_keyframes.erase(i);

}

DCHECK_GE(m_keyframes.size(), 2U);

}