third_party/WebKit/Source/core/events/GenericEventQueue.cpp - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/events/GenericEventQueue.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/events/GenericEventQueue.cpp

diff --git a/third_party/WebKit/Source/core/events/GenericEventQueue.cpp b/third_party/WebKit/Source/core/events/GenericEventQueue.cpp

index a100580a2f22b482515abfa91aa142129a7e8f18..ca6f0a7a718446f200e8cd96c4e955352ed5e04e 100644

--- a/third_party/WebKit/Source/core/events/GenericEventQueue.cpp

+++ b/third_party/WebKit/Source/core/events/GenericEventQueue.cpp

@@ -74,7 +74,7 @@ bool GenericEventQueue::cancelEvent(Event* event) {

if (found) {

EventTarget* target = event->target() ? event->target() : m_owner.get();

probe::asyncTaskCanceled(target->getExecutionContext(), event);

- m_pendingEvents.remove(m_pendingEvents.find(event));

+ m_pendingEvents.erase(m_pendingEvents.find(event));

TRACE_EVENT_ASYNC_END2("event", "GenericEventQueue:enqueueEvent", event,

"type", event->type().ascii(), "status",

"cancelled");