Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)
Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
index e5bb61552205bb50e241e5f922e07439c9db3d01..2974dafb998ad8f9acd9a5570c61bc5943d663ce 100644
--- a/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/RejectedPromises.cpp
@@ -222,7 +222,7 @@ void RejectedPromises::handlerAdded(v8::PromiseRejectMessage data) {
WTF::bind(&RejectedPromises::revokeNow,
RefPtr<RejectedPromises>(this),
WTF::passed(std::move(message))));
- m_reportedAsErrors.remove(i);
+ m_reportedAsErrors.erase(i);
return;
}
}
@@ -261,7 +261,7 @@ void RejectedPromises::processQueueNow(std::unique_ptr<MessageQueue> queue) {
// Remove collected handlers.
for (size_t i = 0; i < m_reportedAsErrors.size();) {
if (m_reportedAsErrors.at(i)->isCollected())
- m_reportedAsErrors.remove(i);
+ m_reportedAsErrors.erase(i);
else
++i;
}
@@ -275,7 +275,7 @@ void RejectedPromises::processQueueNow(std::unique_ptr<MessageQueue> queue) {
message->makePromiseWeak();
m_reportedAsErrors.push_back(std::move(message));
if (m_reportedAsErrors.size() > maxReportedHandlersPendingResolution)
- m_reportedAsErrors.remove(0, maxReportedHandlersPendingResolution / 10);
+ m_reportedAsErrors.erase(0, maxReportedHandlersPendingResolution / 10);
}
}
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/bindings/core/v8/ScriptPromisePropertyBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698