third_party/WebKit/Source/core/dom/Element.cpp - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Element.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Element.cpp

diff --git a/third_party/WebKit/Source/core/dom/Element.cpp b/third_party/WebKit/Source/core/dom/Element.cpp

index 54669b40f5a9bb14fca0be788e54c62ba68c47dd..ede160ed3cbf49311ac05533384ec175944039e4 100644

--- a/third_party/WebKit/Source/core/dom/Element.cpp

+++ b/third_party/WebKit/Source/core/dom/Element.cpp

@@ -3748,7 +3748,7 @@ void Element::detachAttrNodeFromElementWithValue(Attr* attrNode,

AttrNodeList* list = attrNodeList();

size_t index = list->find(attrNode);

DCHECK_NE(index, kNotFound);

- list->remove(index);

+ list->erase(index);

if (list->isEmpty())

removeAttrNodeList();

}