third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp - Issue 2776203002: Migrate WTF::Vector::remove() to ::erase()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

Issue 2776203002: Migrate WTF::Vector::remove() to ::erase() (Closed)

Patch Set: rebase, repatch VectorTest Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/MediaStream.cpp ('k') | third_party/WebKit/Source/modules/sensor/SensorProxy.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

index fcea99b69faf1737293ee78a5592fd1dcd3292d2..e579e4ea5b8dbddaefefdc66952172ef8493a971 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCPeerConnection.cpp

@@ -1121,7 +1121,7 @@ void RTCPeerConnection::removeStream(MediaStream* stream,

if (pos == kNotFound)

return;

- m_localStreams.remove(pos);

+ m_localStreams.erase(pos);

m_peerHandler->removeStream(stream->descriptor());

}

@@ -1331,7 +1331,7 @@ void RTCPeerConnection::didRemoveRemoteStream(

size_t pos = m_remoteStreams.find(stream);

DCHECK(pos != kNotFound);

- m_remoteStreams.remove(pos);

+ m_remoteStreams.erase(pos);

scheduleDispatchEvent(

MediaStreamEvent::create(EventTypeNames::removestream, stream));